Skip to content

Update API Client#83

Merged
etserend merged 1 commit into
mainfrom
chore/splunk-ao-automation/update-api-client-2026-07-14-29355396309
Jul 16, 2026
Merged

Update API Client#83
etserend merged 1 commit into
mainfrom
chore/splunk-ao-automation/update-api-client-2026-07-14-29355396309

Conversation

@etserend

Copy link
Copy Markdown
Contributor

Fix any breaking changes if this pull request fails to deploy

@etserend etserend added the dependencies Pull requests that update a dependency file label Jul 14, 2026
@shuningc

Copy link
Copy Markdown
Contributor

Summary

This PR picks up the automated API client update from 717f3b1 (Update API Client, July 14) and fixes the hand-written SDK code that broke as a result of two breaking changes in the
regenerated client:

  1. IntegrationName renamed to IntegrationProvider

The upstream OpenAPI spec renamed the IntegrationName enum to IntegrationProvider (file integration_name.py → integration_provider.py, LABELSTUDIO value also removed). Updated all references
in:

  • src/splunk_ao/integration.py
  • src/splunk_ao/provider.py
  • src/splunk_ao/resources/models/init.py
  • tests/test_integration.py
  1. type_ removed from ProjectUpdate

The new spec dropped type_ from the ProjectUpdate model. Updated:

  • src/splunk_ao/project.py — removed type_=self.type from the ProjectUpdate constructor call and the corresponding response attribute sync
  • tests/test_project.py — removed the updated_response.type_ = RESOURCES_UNSET setup that is no longer valid

Testing

All 1819 tests pass locally (invoke test-report-xml). Type check clean (invoke type-check).

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Automated client regeneration; the two hand-written breaking-change fixes are correct, complete, and fully propagated with no dangling references.

Fixing ci pipeline after openapi.yml update

Fixing failed tests
@etserend
etserend force-pushed the chore/splunk-ao-automation/update-api-client-2026-07-14-29355396309 branch from 18333f7 to f6319f5 Compare July 16, 2026 17:55
@etserend
etserend merged commit 0ea5caf into main Jul 16, 2026
13 checks passed
@etserend
etserend deleted the chore/splunk-ao-automation/update-api-client-2026-07-14-29355396309 branch July 16, 2026 18:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants