feat(core): bump galileo-core to ^4.4.0, drop fallback ControlSpan tests (HYBIM-788)#75
Conversation
148a1ab to
ccf6f12
Compare
Port fidelity review — nothing is being lost ✅Compared upstream commit Per-file check
Specifically confirmed not lost
Two deviations from upstream — both intentional and harmless
Note (not a defect)The installed 4.4.0 wheel's in-package No changes needed — the port is complete and correct. 🤖 Generated with Claude Code |
fercor-cisco
left a comment
There was a problem hiding this comment.
Approved but there is a merge conflict you will need to resolve.
…sts (HYBIM-788) Ports upstream commit fa93ab2 from rungalileo/galileo-python. galileo-core 4.4.0 ships native ControlSpan unconditionally, so the builtins.__import__ + importlib.reload fallback test machinery is no longer needed. Replace the two fallback tests with direct native equivalents and remove the now-unused top-level module imports from both test files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…evert) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
b144133 to
e16e1d8
Compare
What changed since this PR was last approved (at commit
|
Summary
Port of upstream commit
fa93ab2fromrungalileo/galileo-python(#615) — third commit in the HYBIM-788 migration.galileo-corefrom^4.3.0→^4.4.0in both main deps and test grouppoetry lockto update the lock file to galileo-core 4.4.0test_logged_trace_roundtrip_with_fallback_control_spanandtest_fallback_control_span_rejects_non_uuidish_id_fieldswith direct native equivalents — thebuiltins.__import__+importlib.reloadfallback machinery is dead code now that 4.4.0 ships native ControlSpan unconditionallybuiltins,importlib, threesplunk_ao.*module refs) from both test filesNamespace translation applied
No
from galileo.*refs — this commit only touchespyproject.toml,poetry.lock, and two test files.galileo-coredep name is intentionally unchanged (external dep).Test plan
poetry run pytest tests/schemas/test_logged.py tests/test_agent_control_bridge.py -v— 49 passedpoetry run ruff check src/splunk_ao/ --exclude src/splunk_ao/resources/— cleangrep -r "from galileo\." src/splunk_ao/— no resultsPart of
HYBIM-788 — commits applied in order: 3 of 3 (e42a569 → 6ccd06a → fa93ab2)
Stacked on: #74 (feat/HYBIM-788-port-6ccd06a — jsonl_flat)
🤖 Generated with Claude Code