Skip to content

feat(rebrand): rename Galileo* classes to SplunkAO* (HYBIM-716)#4

Merged
adityamehra merged 5 commits into
mainfrom
feat/rename-classes-splunk-ao
Jun 15, 2026
Merged

feat(rebrand): rename Galileo* classes to SplunkAO* (HYBIM-716)#4
adityamehra merged 5 commits into
mainfrom
feat/rename-classes-splunk-ao

Conversation

@adityamehra

@adityamehra adityamehra commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

Mechanical hard cut-over: renames 23 Python classes from `Galileo*` to `SplunkAO*`
as part of the Splunk Agent Observability rebrand.

Jira ticket: HYBIM-716
Stacked on: #3 — rename `GALILEO_` env vars to `SPLUNK_AO_`
Mirror of: rungalileo/galileo-python#598

This is the authoritative version of this change for the `splunk-ao-python` repo.
The `rungalileo/galileo-python` PR (#598) is kept for upstream awareness.


Class renames

Old New
`GalileoPythonConfig` `SplunkAOConfig`
`GalileoDecorator` `SplunkAODecorator`
`GalileoLogger` `SplunkAOLogger`
`GalileoLoggerSingleton` `SplunkAOLoggerSingleton`
`GalileoMetric` `SplunkAOMetric`
`GalileoMetrics` `SplunkAOMetrics`
`_GalileoScorersProxyMeta` `_SplunkAOScorersProxyMeta`
`_GalileoScorersProxy` `_SplunkAOScorersProxy`
`GalileoLoggerException` `SplunkAOLoggerException`
`GalileoAPIError` `SplunkAOAPIError`
`GalileoFutureError` `SplunkAOFutureError`
`GalileoOTLPExporter` `SplunkAOOTLPExporter`
`GalileoSpanProcessor` `SplunkAOSpanProcessor`
`GalileoBaseHandler` `SplunkAOBaseHandler`
`GalileoAsyncBaseHandler` `SplunkAOAsyncBaseHandler`
`_GalileoControlEventSink` `_SplunkAOControlEventSink`
`GalileoAgentControlBridge` `SplunkAOAgentControlBridge`
`GalileoCallback` `SplunkAOCallback`
`GalileoAsyncCallback` `SplunkAOAsyncCallback`
`GalileoMiddleware` `SplunkAOMiddleware`
`GalileoTracingProcessor` `SplunkAOTracingProcessor`
`GalileoCustomSpan` `SplunkAOCustomSpan`
`OpenAIGalileo` `OpenAISplunkAO`

Not renamed: `GalileoScorers` (out of scope per HYBIM-716).

Key decisions

  • Hard cut-over — old names removed entirely, no deprecated aliases
  • 94 files updated — 59 src files + 35 test files
  • `galileo-core` unaffected — core is an upstream dependency; it doesn't import from this SDK

Test plan

  • `poetry run pytest` — 2015 passed, 5 skipped
  • `langchain-agent` example — `SplunkAOCallback` in use, exit 0
  • `strands-agents` example — exit 0
  • E2E tests — pre-existing server-side failures only, unrelated to this change

…6, 727)

Co-authored-by: Cursor <cursoragent@cursor.com>
@adityamehra adityamehra force-pushed the feat/rename-env-vars-splunk-ao branch from 8f0da56 to f7efcdf Compare June 8, 2026 20:34
Co-authored-by: Cursor <cursoragent@cursor.com>
@adityamehra adityamehra force-pushed the feat/rename-classes-splunk-ao branch from 10708e6 to 62dafd1 Compare June 8, 2026 20:34
fercor-cisco
fercor-cisco previously approved these changes Jun 12, 2026
@adityamehra adityamehra changed the base branch from feat/rename-env-vars-splunk-ao to main June 12, 2026 20:02
@adityamehra adityamehra dismissed fercor-cisco’s stale review June 12, 2026 20:02

The base branch was changed.

adityamehra and others added 2 commits June 12, 2026 13:17
Resolve conflicts by keeping SplunkAO* class names (SplunkAOConfig,
SplunkAOLoggerSingleton, SplunkAOMetrics, SplunkAOOTLPExporter) over
stale Galileo* references introduced in main, consistent with the
rebranding goal of this PR.

Co-authored-by: Cursor <cursoragent@cursor.com>

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: request_changes — Hard cut-over removed class names still imported at runtime by in-repo sibling packages (galileo-adk) and example/doc code, breaking imports.

General Comments

  • 🔴 critical (bug): This PR is a "hard cut-over" that removes the old Galileo* class names with no compatibility aliases, but it only updated src/galileo and tests/. The monorepo contains sibling packages — galileo-adk and galileo-a2a — that depend on galileo via an editable path dependency (galileo-adk/pyproject.toml: sources = { galileo = { path = "../", editable = true } }) and still import the removed names. Concretely, galileo-adk/src/galileo_adk/observer.py and span_manager.py import GalileoBaseHandler and use it at runtime (e.g. observer.py:150,159,173), so galileo-adk now fails at import time. galileo-adk/tests/conftest.py imports the removed GalileoPythonConfig and GalileoLoggerSingleton. These packages need to be migrated in this PR (or in a coordinated change), otherwise the rebrand breaks them. Please either (a) extend the rename to galileo-adk/galileo-a2a, or (b) provide temporary aliases for the affected public names.
  • 🟠 major (documentation): The README and example scripts still reference the removed public names, so docs/examples no longer work after this rename. examples/langgraph/basic_langgraph.py and examples/langgraph/with_openai.py import GalileoCallback at module level (now an ImportError when run). README.md documents GalileoLogger and GalileoCallback as importable public symbols (e.g. from galileo import GalileoLogger), which will raise ImportError for users following the docs. Since this PR is the rebrand, these user-facing references should be updated as part of it (or captured/tracked explicitly if intentionally deferred).

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

  • galileo-a2a/src/galileo_a2a/instrumentor.py:35-39: The docstring example references the old GalileoSpanProcessor / add_galileo_span_processor import (not executed, so not a runtime break). Update the docstring and the galileo-a2a/README.md / galileo-a2a/examples/two_agent_demo.py references to SplunkAOSpanProcessor for consistency with the rebrand.
  • galileo-adk/CONTRIBUTING.md:51-83: galileo-adk docs (CONTRIBUTING.md, README.md) still describe GalileoBaseHandler / GalileoLogger. Refresh these once the galileo-adk source migration lands.

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct and ready for merging.

galileo-adk, galileo-a2a, documentation, docstrings, and function names will be handled as follow-ups.

@adityamehra adityamehra merged commit 70ea0d3 into main Jun 15, 2026
16 checks passed
@adityamehra adityamehra deleted the feat/rename-classes-splunk-ao branch June 15, 2026 22:46
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants