feat(rebrand): rename Galileo* classes to SplunkAO* (HYBIM-716)#4
Merged
Conversation
…6, 727) Co-authored-by: Cursor <cursoragent@cursor.com>
8f0da56 to
f7efcdf
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
10708e6 to
62dafd1
Compare
fercor-cisco
previously approved these changes
Jun 12, 2026
Resolve conflicts by keeping SplunkAO* class names (SplunkAOConfig, SplunkAOLoggerSingleton, SplunkAOMetrics, SplunkAOOTLPExporter) over stale Galileo* references introduced in main, consistent with the rebranding goal of this PR. Co-authored-by: Cursor <cursoragent@cursor.com>
fercor-cisco
left a comment
Collaborator
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent. It may contain mistakes.
Verdict: request_changes — Hard cut-over removed class names still imported at runtime by in-repo sibling packages (galileo-adk) and example/doc code, breaking imports.
General Comments
- 🔴 critical (bug): This PR is a "hard cut-over" that removes the old
Galileo*class names with no compatibility aliases, but it only updatedsrc/galileoandtests/. The monorepo contains sibling packages —galileo-adkandgalileo-a2a— that depend ongalileovia an editable path dependency (galileo-adk/pyproject.toml:sources = { galileo = { path = "../", editable = true } }) and still import the removed names. Concretely,galileo-adk/src/galileo_adk/observer.pyandspan_manager.pyimportGalileoBaseHandlerand use it at runtime (e.g.observer.py:150,159,173), sogalileo-adknow fails at import time.galileo-adk/tests/conftest.pyimports the removedGalileoPythonConfigandGalileoLoggerSingleton. These packages need to be migrated in this PR (or in a coordinated change), otherwise the rebrand breaks them. Please either (a) extend the rename togalileo-adk/galileo-a2a, or (b) provide temporary aliases for the affected public names. - 🟠 major (documentation): The README and example scripts still reference the removed public names, so docs/examples no longer work after this rename.
examples/langgraph/basic_langgraph.pyandexamples/langgraph/with_openai.pyimportGalileoCallbackat module level (now an ImportError when run).README.mddocumentsGalileoLoggerandGalileoCallbackas importable public symbols (e.g.from galileo import GalileoLogger), which will raise ImportError for users following the docs. Since this PR is the rebrand, these user-facing references should be updated as part of it (or captured/tracked explicitly if intentionally deferred).
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
galileo-a2a/src/galileo_a2a/instrumentor.py:35-39: The docstring example references the oldGalileoSpanProcessor/add_galileo_span_processorimport (not executed, so not a runtime break). Update the docstring and thegalileo-a2a/README.md/galileo-a2a/examples/two_agent_demo.pyreferences toSplunkAOSpanProcessorfor consistency with the rebrand.galileo-adk/CONTRIBUTING.md:51-83: galileo-adk docs (CONTRIBUTING.md, README.md) still describeGalileoBaseHandler/GalileoLogger. Refresh these once the galileo-adk source migration lands.
fercor-cisco
approved these changes
Jun 15, 2026
fercor-cisco
left a comment
Collaborator
There was a problem hiding this comment.
The changes are correct and ready for merging.
galileo-adk, galileo-a2a, documentation, docstrings, and function names will be handled as follow-ups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical hard cut-over: renames 23 Python classes from `Galileo*` to `SplunkAO*`
as part of the Splunk Agent Observability rebrand.
Jira ticket: HYBIM-716
Stacked on: #3 — rename `GALILEO_` env vars to `SPLUNK_AO_`
Mirror of: rungalileo/galileo-python#598
Class renames
Not renamed: `GalileoScorers` (out of scope per HYBIM-716).
Key decisions
Test plan