HYBIM-800 Adding changes for parameter names renaming#35
Conversation
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent. It may contain mistakes.
Verdict: request_changes — Rename is complete within splunk_ao/ but breaks the in-repo galileo-adk consumer, which still uses the old galileo_logger API.
General Comments
-
🔴 critical (bug): This rename is incomplete across the monorepo.
SplunkAOBaseHandler.__init__now only acceptssplunk_ao_logger(the parameter was renamed fromgalileo_logger, and there is no**kwargs), and the private attribute is now_splunk_ao_logger. But the sibling packagegalileo-adk— which installs this package via an editable path dependency ([tool.uv] sources = { galileo = { path = "../", editable = true } }) — still uses the old API: -
galileo-adk/src/galileo_adk/observer.py:152and:161callSplunkAOBaseHandler(galileo_logger=...), which will now raiseTypeError: __init__() got an unexpected keyword argument 'galileo_logger'. -
galileo-adk/src/galileo_adk/observer.py:294readsself._handler._galileo_logger, andgalileo-adk/tests/test_callback.py:136/test_observer.py:219,232,244,257,270read._galileo_logger— these will now raiseAttributeError.
This breaks galileo-adk at runtime and will fail its test suite. Update observer.py and the galileo-adk tests to use splunk_ao_logger / _splunk_ao_logger as part of this PR (or in a coordinated change), otherwise the rebrand leaves the monorepo in a broken state. Please also grep the whole monorepo (galileo-a2a was clean, but confirm) for any remaining galileo_logger references before merging.
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
tests/test_openai_agents_utils.py:299-299: For consistency with the rebrand, consider renaming the test methodtest_galileo_custom_span(and thegalileo_spanlocal var) totest_splunk_ao_custom_span. Cosmetic only — does not affect behavior.tests/test_logger_batch.py:1738-1738: Theenable_galileo_loggingfixture (in tests/conftest.py) was left un-renamed while its internal variable was renamed. Non-blocking, but renaming the fixture toenable_splunk_ao_loggingwould complete the rebrand consistently.
fercor-cisco
left a comment
There was a problem hiding this comment.
There's another ticket for renaming galileo-adk so we can go ahead and merge this.
Renames all remaining galileo-prefixed identifiers within the splunk_ao package as part of the SDK rebrand effort.
Changes:
log_streams.py, experiments.py, and handler files
base_async_handler.py, crewai/handler.py, langchain/handler.py, langchain/async_handler.py, langchain/middleware.py, openai_agents/handler.py,
agent_control/bridge.py), openai/init.py, openai/extractors.py, configuration.py, and logger/logger.py