Skip to content

HYBIM-800 Adding changes for parameter names renaming#35

Merged
shuningc merged 3 commits into
mainfrom
HYBIM-800-parameters-renaming
Jun 18, 2026
Merged

HYBIM-800 Adding changes for parameter names renaming#35
shuningc merged 3 commits into
mainfrom
HYBIM-800-parameters-renaming

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Renames all remaining galileo-prefixed identifiers within the splunk_ao package as part of the SDK rebrand effort.

Changes:

  • galileo_context → splunk_ao_context — the global SplunkAODecorator singleton and all references across agent_control.py, tracing.py, log_stream.py,
    log_streams.py, experiments.py, and handler files
  • galileo_dataset_context → splunk_ao_dataset_context — the dataset context manager in decorator.py and experiments.py
  • galileo_logger / _galileo_logger → splunk_ao_logger / _splunk_ao_logger — parameter name and private attribute across all handler files (base_handler.py,
    base_async_handler.py, crewai/handler.py, langchain/handler.py, langchain/async_handler.py, langchain/middleware.py, openai_agents/handler.py,
    agent_control/bridge.py), openai/init.py, openai/extractors.py, configuration.py, and logger/logger.py
  • _galileo_loggers → _splunk_ao_loggers — private cache attribute in utils/singleton.py
  • "galileo_custom" → "splunk_ao_custom" — internal span type discriminator literal in utils/openai_agents.py and handlers/openai_agents/handler.py
  • galileo_type → splunk_ao_type — local variable in handlers/openai_agents/handler.py
  • Updated all corresponding test files to match the renamed parameters and attributes

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: request_changes — Rename is complete within splunk_ao/ but breaks the in-repo galileo-adk consumer, which still uses the old galileo_logger API.

General Comments

  • 🔴 critical (bug): This rename is incomplete across the monorepo. SplunkAOBaseHandler.__init__ now only accepts splunk_ao_logger (the parameter was renamed from galileo_logger, and there is no **kwargs), and the private attribute is now _splunk_ao_logger. But the sibling package galileo-adk — which installs this package via an editable path dependency ([tool.uv] sources = { galileo = { path = "../", editable = true } }) — still uses the old API:

  • galileo-adk/src/galileo_adk/observer.py:152 and :161 call SplunkAOBaseHandler(galileo_logger=...), which will now raise TypeError: __init__() got an unexpected keyword argument 'galileo_logger'.

  • galileo-adk/src/galileo_adk/observer.py:294 reads self._handler._galileo_logger, and galileo-adk/tests/test_callback.py:136 / test_observer.py:219,232,244,257,270 read ._galileo_logger — these will now raise AttributeError.

This breaks galileo-adk at runtime and will fail its test suite. Update observer.py and the galileo-adk tests to use splunk_ao_logger / _splunk_ao_logger as part of this PR (or in a coordinated change), otherwise the rebrand leaves the monorepo in a broken state. Please also grep the whole monorepo (galileo-a2a was clean, but confirm) for any remaining galileo_logger references before merging.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

  • tests/test_openai_agents_utils.py:299-299: For consistency with the rebrand, consider renaming the test method test_galileo_custom_span (and the galileo_span local var) to test_splunk_ao_custom_span. Cosmetic only — does not affect behavior.
  • tests/test_logger_batch.py:1738-1738: The enable_galileo_logging fixture (in tests/conftest.py) was left un-renamed while its internal variable was renamed. Non-blocking, but renaming the fixture to enable_splunk_ao_logging would complete the rebrand consistently.

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another ticket for renaming galileo-adk so we can go ahead and merge this.

@shuningc
shuningc merged commit b88b1d6 into main Jun 18, 2026
16 checks passed
@shuningc
shuningc deleted the HYBIM-800-parameters-renaming branch June 18, 2026 18:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants