-
Notifications
You must be signed in to change notification settings - Fork 2
fix(galileo-a2a): Rebrand to SPLUNK_AO_* env vars and SplunkAOSpanProcessor and Rename package to splunk-ao-a2a and reset to v0.1.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a6a0479
6afc9bd
6d0aa1d
79f1996
a739344
005daa2
d5bad72
5d175f9
c2ad927
8c2a462
4512c71
e605a4d
5485c6f
3f98825
4934d3a
a8ceb17
c5393ed
9972409
99697dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| name: Test splunk-ao-a2a | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'splunk-ao-a2a/**' | ||
| - '.github/workflows/ci-tests-splunk-ao-a2a.yaml' | ||
| pull_request: | ||
| paths: | ||
| - 'splunk-ao-a2a/**' | ||
| - '.github/workflows/ci-tests-splunk-ao-a2a.yaml' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Python ${{ matrix.python-version }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.11", "3.12", "3.13", "3.14"] | ||
|
|
||
| runs-on: ubuntu-latest | ||
| # Hard cap per matrix job to bail out fast on real hangs. | ||
| timeout-minutes: 30 | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: splunk-ao-a2a | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867 # v7.1.6 | ||
| with: | ||
| enable-cache: true | ||
| cache-dependency-glob: "**/splunk-ao-a2a/pyproject.toml" | ||
|
|
||
| # uv sources in pyproject.toml pins splunk-ao to the local monorepo root | ||
| # as an editable install, so this always tests against the latest local code. | ||
| - name: Install dependencies | ||
| run: uv sync --dev | ||
|
|
||
| - name: Show installed versions | ||
| run: uv pip list | grep -E "^(galileo|a2a-sdk|splunk-ao)" | ||
|
|
||
| - name: Run type check | ||
| run: uv run mypy src/ | ||
|
|
||
| - name: Run tests | ||
| run: uv run pytest --cov=splunk_ao_a2a --cov-report=xml |
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| SPLUNK_AO_API_KEY=your-splunk-ao-key | ||
| SPLUNK_AO_CONSOLE_URL=https://<splunk-ao-console-host> | ||
| SPLUNK_AO_PROJECT=a2a-distributed-tracing-demo | ||
| SPLUNK_AO_LOG_STREAM=dev | ||
| OPENAI_API_KEY=your-openai-key |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
🟡 minor (documentation): Stale
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @fercor-cisco fixed! |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| from splunk_ao_a2a._version import __version__ | ||
| from splunk_ao_a2a.instrumentor import A2AInstrumentor | ||
|
|
||
| __all__ = ["A2AInstrumentor", "__version__"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 minor (documentation): This link was rebranded to "Splunk AO Documentation" but the URL still points at Galileo (
https://docs.galileo.ai), and it was changed from the originalv2docs.galileo.aitodocs.galileo.aiin the process. The label and target are now inconsistent, and the new host may not resolve. Point this at the actual Splunk AO docs (or revert the URL to the working Galileo one until a Splunk docs site exists).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fercor-cisco this is in line with the discussion and what has been already done for examples and adk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, we're keeping the previous URL for now