Skip to content

HYBIM-728 Renaming SDK Identifiers from galileo to splunk_ao#11

Merged
shuningc merged 5 commits into
mainfrom
HYBIM-728-renameSDKIdentifiers-clean
Jun 17, 2026
Merged

HYBIM-728 Renaming SDK Identifiers from galileo to splunk_ao#11
shuningc merged 5 commits into
mainfrom
HYBIM-728-renameSDKIdentifiers-clean

Conversation

@shuningc

@shuningc shuningc commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Renames all public function, method, and module-level instance identifiers from galileo_* to splunk_ao_*, and renames the GALILEO_HEADER_PREFIX constant to
SPLUNK_AO_HEADER_PREFIX. All call sites, imports, docstrings, tests, READMEs, and AGENTS.md are updated across src/, tests/, galileo-adk/, and
galileo-a2a/.

What was renamed

Functions / methods / instances

  • galileo_context → splunk_ao_context
  • galileo_dataset_context → splunk_ao_dataset_context
  • galileo_logging_enabled → splunk_ao_logging_enabled
  • convert_to_galileo_message → convert_to_splunk_ao_message
  • get_galileo_args → get_splunk_ao_args
  • add_galileo_span_processor → add_splunk_ao_span_processor
  • start_galileo_span → start_splunk_ao_span
  • _galileo_wrapper → _splunk_ao_wrapper
  • _with_galileo → _with_splunk_ao
  • add_galileo_custom_span → add_splunk_ao_custom_span
  • galileo_retriever → splunk_ao_retriever
  • _galileo_is_retriever → _splunk_ao_is_retriever
  • convert_adk_content_to_galileo_messages → convert_adk_content_to_splunk_ao_messages
  • convert_adk_tools_to_galileo_format → convert_adk_tools_to_splunk_ao_format

Constants

  • GALILEO_HEADER_PREFIX → SPLUNK_AO_HEADER_PREFIX (wire value "X-Galileo" unchanged)

Intentionally left unchanged

  • Class names (GalileoLogger, GalileoCallback, etc.) — deferred to follow-up
  • Environment variable strings (GALILEO_API_KEY, GALILEO_PROJECT, etc.) — user-facing config, requires separate deprecation
  • Wire header values (X-Galileo-Trace-ID, X-Galileo-Parent-ID, X-Galileo-SDK) — backend must be updated first
  • galileo_core imports — external package, out of scope
  • src/galileo/resources/ — auto-generated from OpenAPI spec, never edited manually

Testing

All 2015 unit tests pass with no failures.

@shuningc shuningc changed the title Renaming SDK Identifiers from galileo to splunk_ao HYBIM-728 Renaming SDK Identifiers from galileo to splunk_ao Jun 5, 2026

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: approve — Clean, internally-complete identifier rename; only a misleading comment about the header wire format needs fixing.

# These headers follow the pattern of namespaced custom headers (X-Galileo-*)
TRACE_ID_HEADER = f"{GALILEO_HEADER_PREFIX}-Trace-ID"
PARENT_ID_HEADER = f"{GALILEO_HEADER_PREFIX}-Parent-ID"
# These headers follow the pattern of namespaced custom headers (Splunk-AO-*)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 minor (documentation): This comment was changed to claim the headers follow the Splunk-AO-* pattern, but the actual emitted header values are unchanged: SPLUNK_AO_HEADER_PREFIX = "X-Galileo", so TRACE_ID_HEADER/PARENT_ID_HEADER resolve to X-Galileo-Trace-ID / X-Galileo-Parent-ID. The PR description explicitly states wire header values are intentionally left unchanged until the backend is updated. The previous comment (X-Galileo-*) was correct; the new text is now misleading. Revert the pattern in the comment to match the real wire format.

Suggested change
# These headers follow the pattern of namespaced custom headers (Splunk-AO-*)
# These headers follow the pattern of namespaced custom headers (X-Galileo-*)

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small note on the Jira ticket that seems to have been overlooked.

As part of this ticket, we also want to change the string literal for the header prefix from "X-Galileo" to "Splunk-AO".

Any other code, test, docstring or comment that mentions the old header prefix also needs to be udpated.

This is what Claude Code came up with:


  1. The constant value (the core change)
  • src/splunk_ao/constants/init.py:11 — SPLUNK_AO_HEADER_PREFIX = "X-Galileo" → "Splunk-AO"

Once this changes, TRACE_ID_HEADER and PARENT_ID_HEADER in tracing.py will automatically resolve to the new values.


  1. Hardcoded X-Galileo-SDK in production code (this header isn't covered by the constant) -- if possible change the code to use SPLUNK_AO_HEADER_PREFIX
  • src/splunk_ao/traces.py:63,189 — "X-Galileo-SDK" → "Splunk-AO-SDK"
  • src/splunk_ao/experiments.py:678,745 — "X-Galileo-SDK" → "Splunk-AO-SDK"

  1. Docstrings and comments in production code
  • src/splunk_ao/constants/tracing.py:6 — comment (X-Galileo-) → (Splunk-AO-) (the reviewer's fix)
  • src/splunk_ao/tracing.py:16 — docstring mentions X-Galileo-Trace-ID / X-Galileo-Parent-ID
  • src/splunk_ao/logger/logger.py:941-965 — docstring and example comments with X-Galileo-Trace-ID / X-Galileo-Parent-ID
  • src/splunk_ao/middleware/tracing.py:91-92,160-161 — docstrings with X-Galileo-Trace-ID / X-Galileo-Parent-ID
  • src/splunk_ao/utils/headers_data.py:64 — docstring mentions X-Galileo-SDK

  1. Tests asserting on literal header strings
  • tests/test_logger_distributed.py:1878-1881,1903-1906 — asserts on "X-Galileo-Trace-ID" / "X-Galileo-Parent-ID"
  • tests/test_api_headers.py — multiple asserts on "X-Galileo-SDK" (lines 41,42,45,56,75,90,91)
  • tests/test_traces_client_headers.py:43-47 — asserts on "X-Galileo-SDK"

  1. Test docstrings/comments
  • tests/test_middleware_tracing.py:213 — docstring mentions X-Galileo-Trace-ID / X-Galileo-Parent-ID
  • tests/test_api_headers.py:1,15,34,35,49 — module/class/method docstrings mentioning X-Galileo-SDK
  • tests/test_traces_client_headers.py:1,13,35,43 — same

Out of scope: src/galileo/resources/ is auto-generated from the OpenAPI spec — those "X-Galileo-SDK" usages should not be edited manually.

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header prefix change will be done separately.

@shuningc
shuningc merged commit 88fd42e into main Jun 17, 2026
16 checks passed
@shuningc
shuningc deleted the HYBIM-728-renameSDKIdentifiers-clean branch June 17, 2026 00:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants