Bug fix: Key delimiters are now case insensitive#2084
Open
maxBRT wants to merge 8 commits intospf13:masterfrom
Open
Bug fix: Key delimiters are now case insensitive#2084maxBRT wants to merge 8 commits intospf13:masterfrom
maxBRT wants to merge 8 commits intospf13:masterfrom
Conversation
|
|
spacez320
reviewed
Oct 15, 2025
Contributor
|
I plan on reviewing this soon. cc @sagikazarmark |
Contributor
|
Apologies for the delay, I do still mean to review this. For now I'll probably lay down some superficial comments, but I intend to do a proper thorough review next week. |
spacez320
reviewed
Oct 25, 2025
spacez320
reviewed
Oct 31, 2025
Contributor
spacez320
left a comment
spacez320
left a comment
There was a problem hiding this comment.
Thank you for continued work, this seems close. In addition to the tweaks, I would just add a little note in the readme around the delimeter section telling people delimeters are always lowercased, like keys.
Co-authored-by: Matthew Coleman <matthew.e.coleman@gmail.com>
Co-authored-by: Matthew Coleman <matthew.e.coleman@gmail.com>
Co-authored-by: Matthew Coleman <matthew.e.coleman@gmail.com>
Clarify that the delimiter is case-insensitive for alphabetic characters.
Contributor
|
/label release-note/bug-fix |
spacez320
approved these changes
Nov 2, 2025
Contributor
spacez320
left a comment
spacez320
left a comment
There was a problem hiding this comment.
This looks good to me.
Contributor
|
@sagikazarmark I believe this is ready for your consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply added the
strings.ToLower(v.keyDelim))as suggested and wrote a small test for it.Fixes #2069