qt: add Changelog to Help menu in toolbar #10433
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
force-pushed
the
qt_changelog
branch
4 times, most recently
from
f7035a6 to
1ca6b74
Compare
Adds a "Changelog" action to the "Help" menu of the toolbar. This allows users to open the RELEASE-NOTES file in the browser (from github).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Changelogitem to the Help menu of the toolbar. Clicking on the item opens the changelog in the browser (github text-only form).The dialog reads and shows the RELEASE-NOTES file or shows a link to the release notes on github as fallback.Reading the RELEASE-NOTES file feels a bit fragile but there is a fallback to open the github release notes in the browser, not sure if this is the best approach?This way at least the main path is not dependent on the web/github.
I tested the AppImage, windows and macos builds.
Edit:
Changed this to just open the changelog in the browser, this seems much less fragile to maintain and doesn't require bundling the RELEASE-NOTES in the binaries.