Add Image Captions on Thumbnail View - #77
Conversation
grantfitzsimmons
left a comment
grantfitzsimmons
left a comment
There was a problem hiding this comment.
It looks like this PR includes the changes for #76 as well as the changes to add image captions in thumbnail views.
I really appreciate the way this was added (adding a new setting named displayImgCaption that can be toggled on or off) to make it simple and optional for users. Great work and thank you so much @warrenhbrown!
|
@specify/dev-testing This code is live on their Fish Web Portal. When testing, we need to set up a new instance and verify that the |
58672e7 to
e1d8c84
Compare
...not just the first.
The current float-based layout for image thumbnails results in irregular gaps due to the variability in image caption height.
There was a problem hiding this comment.
Here's an example of the layout issue we observed due to longer caption lengths that affect rendering height. The existing css float rule remains in place to support older browsers, if needed.
Commit w/ potential fix: d628eac
4 participants
This pull request adds support for displaying a caption under the images in the thumbnail view. settings.json is extended with: displayImgCaption: when set to true, the fields (as configured in imageInfoFlds, see above) will render underneath preview views and the image detail view.