feat(core/github): support custom pullsURL and commitHistoryURL#5100
Merged
sidvishnoi merged 17 commits intospeced:mainfrom Feb 20, 2026
Merged
feat(core/github): support custom pullsURL and commitHistoryURL#5100sidvishnoi merged 17 commits intospeced:mainfrom
pullsURL and commitHistoryURL#5100sidvishnoi merged 17 commits intospeced:mainfrom
Conversation
sidvishnoi
changed the title
pullsURL and commitHistoryURL valuespullsURL and commitHistoryURL
sidvishnoi
approved these changes
Feb 20, 2026
Member
|
@daniel-montalvo Please fix lint issues with And ignore unrelated failing tests. Looks like a recent Chromium bug. |
sidvishnoi
changed the title
pullsURL and commitHistoryURLpullsURL and commitsURL
sidvishnoi
requested changes
Feb 20, 2026
sidvishnoi
reviewed
Feb 20, 2026
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
sidvishnoi
changed the title
pullsURL and commitsURLpullsURL and commitHistoryURL
sidvishnoi
reviewed
Feb 20, 2026
Contributor
Author
|
HI @sidvishnoi Thanks for looking into this so quickly. I think I've now addressed all your comments. It's just I cannot for whatever reason dismiss your review. |
Member
|
Looks like we need some fixes. The headless tests and some GitHub/headers tests are genuinely failing. |
sidvishnoi
reviewed
Feb 20, 2026
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Member
|
Looks like the commits URL now always include a branch, so some tests are failing. |
sidvishnoi
reviewed
Feb 20, 2026
sidvishnoi
reviewed
Feb 20, 2026
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
sidvishnoi
reviewed
Feb 20, 2026
sidvishnoi
approved these changes
Feb 20, 2026
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Please update the docs as well, when you can @daniel-montalvo .
Contributor
Author
|
Hi @sidvishnoi
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5042