Open
Conversation
|
|
||
| async function executePreparePass(runnables, config) { | ||
| for (const plug of runnables.filter(p => p.prepare)) { | ||
| config.state[plug.name] = {}; |
Contributor
There was a problem hiding this comment.
Hmm... not a fan of attaching more stuff to config. Why not have this as an internal state inside the plugin itself?
Member
Author
There was a problem hiding this comment.
Plugins can share state among them.
I plan to add a state arg to all functions, but conf.state was easier for starters.
Contributor
There was a problem hiding this comment.
I'd suggest doing that now... look at what happened with my terrible linter API :( I kept saying, "I'll fix it next week... I'll fix it next week..." and years later, still there 😢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will start fetching the axe script earlier, giving some performance improvements.
Also, should help in avoiding jasmine timeouts that we often get in CI [^1].
Extracted from https://github.com/w3c/respec/pull/3319
[^1]