Skip to content

Add SPDX Java library family diagram#359

Merged
bact merged 2 commits into
spdx:masterfrom
bact:family-diagram
Sep 27, 2025
Merged

Add SPDX Java library family diagram#359
bact merged 2 commits into
spdx:masterfrom
bact:family-diagram

Conversation

@bact

@bact bact commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

Add a diagram showing a family of SPDX Java libraries and their relationships to help implementers quickly get the overview.

The diagram is rendered from a PlantUML file.

It will look like this:

spdx_java_lib_family

Add a diagram showing a family of SPDX Java libraries and their relationships to help implementers quickly get the overview.

The diagram is rendered from a PlantUML file.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the documentation Improvements or additions to documentation label Sep 26, 2025
@bact

bact commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

Alternatively, we can remove the spec Turtle file, to make the diagram simpler:

spdx_java_lib_family_without_spec

@pmonks

pmonks commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

A diagram like this will be exceptionally useful to newcomers! Great idea!

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great as is - I just have one suggested improvement.

The SPDX Java Library includes a simple in memory storage implementation.

It may be good to note this - it is storage.simple package inside the library.

If you think it would be confusing to note this detail, we can go with the PR as is.

@bact

bact commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

Thank you. I will find a way to include the in-memory storage.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact

bact commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator Author

@pmonks @goneall the updated diagram, with the in-memory store

spdx_java_lib_family

Another thing, currently the diagram uses "implements" label for a relationship from store to the store interface. SPDX 3 does not have "implements" relationship type, but has "has specification"; should we use that in the diagram or "implements" is fine here?

@bact bact requested review from goneall and pmonks September 27, 2025 10:31
@goneall

goneall commented Sep 27, 2025

Copy link
Copy Markdown
Member

Another thing, currently the diagram uses "implements" label for a relationship from store to the store interface. SPDX 3 does not have "implements" relationship type, but has "has specification"; should we use that in the diagram or "implements" is fine here?

I think Implements is find for the diagram

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@bact bact merged commit 592a9a2 into spdx:master Sep 27, 2025
1 check passed
@bact bact deleted the family-diagram branch September 27, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants