Skip to content

pflare:add new package#1670

Merged
hainest merged 7 commits into
spack:developfrom
stevendargaville:pflare_add_1.24.8
May 23, 2026
Merged

pflare:add new package#1670
hainest merged 7 commits into
spack:developfrom
stevendargaville:pflare_add_1.24.8

Conversation

@stevendargaville

@stevendargaville stevendargaville commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

This add a new package PFLARE (https://github.com/PFLAREProject/PFLARE). It adds methods to PETSc designed for asymmetric linear systems. It depends on PETSc, MPI, BLAS and LAPACK, as well as Python with a variant.

It builds locally on Linux and Mac OSX. I have CI at https://github.com/PFLAREProject/PFLARE_spack that checks spack install succeeds on Ubuntu as well as the one variant. This runs every time the main branch of PFLARE is changed to ensure we don't break anything.

I have added myself as a maintainer and the style has been checked with spack style --fix.

@stevendargaville stevendargaville changed the title pflare:add new package, version 1.24.8 pflare:add new package Nov 13, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity.
If the pull request is waiting for a reply from reviewers, feel free to ping them as a reminder. If it is waiting and has no assigned reviewer, feel free to ping @spack/spack-releasers or simply leave a comment saying this should not be marked stale. This will reset the pull request's stale state.
To get more eyes on your pull request, you can post a link in the #pull-requests channel of the Spack Slack.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 14, 2026

@hainest hainest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHAs confirmed.

Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/pflare/package.py Outdated
@hainest hainest self-assigned this May 17, 2026
@stevendargaville

Copy link
Copy Markdown
Contributor Author

@hainest Thanks for the review, I've made the requested changes and added new versions since the PR was opened.

@hainest

hainest commented May 18, 2026

Copy link
Copy Markdown
Contributor

@spackbot fix style

@spackbot-app

spackbot-app Bot commented May 18, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented May 18, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/pflare/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
Found 1 error (1 fixed, 0 remaining).
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@stevendargaville

Copy link
Copy Markdown
Contributor Author

Apologies I pushed a commit that included the spack style --fix around the same time the spackbot was triggered. Should be ready to go through the final CI now.

@stevendargaville

Copy link
Copy Markdown
Contributor Author

CI is green so I think the PR is ready

@hainest hainest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the suggested fixes!

@hainest hainest merged commit 0daf7d0 into spack:develop May 23, 2026
17 checks passed
@stevendargaville stevendargaville deleted the pflare_add_1.24.8 branch May 24, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants