pflare:add new package#1670
Conversation
|
This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity. |
|
@hainest Thanks for the review, I've made the requested changes and added new versions since the PR was opened. |
8e14c2f to
f267a39
Compare
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/pflare/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
Found 1 error (1 fixed, 0 remaining).
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
f26c9e5 to
b657f25
Compare
|
Apologies I pushed a commit that included the spack style --fix around the same time the spackbot was triggered. Should be ready to go through the final CI now. |
|
CI is green so I think the PR is ready |
hainest
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the suggested fixes!
This add a new package PFLARE (https://github.com/PFLAREProject/PFLARE). It adds methods to PETSc designed for asymmetric linear systems. It depends on PETSc, MPI, BLAS and LAPACK, as well as Python with a variant.
It builds locally on Linux and Mac OSX. I have CI at https://github.com/PFLAREProject/PFLARE_spack that checks spack install succeeds on Ubuntu as well as the one variant. This runs every time the main branch of PFLARE is changed to ensure we don't break anything.
I have added myself as a maintainer and the style has been checked with spack style --fix.