Repository navigation
Resolve the Pi extension roots from Pi's own registration - #834
Merged
clkao merged 2 commits intoOct 6, 2026
Merged
Conversation
The launch path now mirrors the host it launches: an exported PI_SUBAGENTS_PACKAGE_ROOT/PI_INTERCOM_PACKAGE_ROOT wins, else the package registered in the agent directory's settings.json (pi's own discovery), else the default home layout. The winning source label is carried into the doctor report and the ready line so an operator sees which root won.
Close two committed-test gaps from the validation round for PR #834: - Override precedence: PI_SUBAGENTS_PACKAGE_ROOT must win over a competing settings.json registration for pi-subagents, while a package with no override (pi-intercom) still resolves from its registration. - Manifest-name match: a decoy registration first in settings.json whose package.json name differs must not satisfy the pi-subagents lookup; the real manifest-named registration must still resolve. Both tests are RED under the corresponding pi.go mutation and GREEN restored.
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pi launcher on a non-default home demanded a package path Pi itself already resolves, and told the operator to export a variable.
What changed
Evidence
internal/cli/pi.goandpi_frontdoor_test.goonly: net +121, inside the +40..+140 tolerance.launcher