Document that Lenkhebel is not a real steering value on road vehicles - #150
Open
ZackaryH8 wants to merge 1 commit into
Open
Document that Lenkhebel is not a real steering value on road vehicles#150ZackaryH8 wants to merge 1 commit into
ZackaryH8 wants to merge 1 commit into
Conversation
Disassembling Omsi.exe 2.3 shows every real access to TRoadVehicle/TRoadVehicleInst+0x268 (Lenkhebel's offset) as an array-typed field, not a float - writing here has no effect on steering. The value that actually drives steering is OmsiRoadVehicleInst.Inv_LenkRadius (+0x73c), confirmed both as the input to TRoadVehicleInst_CalcFree's per-axle Ackermann geometry and as what the keyboard steering-left/steering-right key handlers directly ramp each frame. Inv_LenkRadius was already correctly wrapped here, just undocumented, so this only adds doc comments cross- referencing the two - Lenkhebel is left unchanged in case some other OmsiMovingMapObjInst subtype genuinely uses that offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disassembling Omsi.exe shows every real access to TRoadVehicle/TRoadVehicleInst+0x268 (Lenkhebel's offset) as an array-typed field, not a float - writing here has no effect on steering. The value that actually drives steering is OmsiRoadVehicleInst.Inv_LenkRadius (+0x73c), confirmed both as the input to TRoadVehicleInst_CalcFree's per-axle Ackermann geometry and as what the keyboard steering-left/steering-right key handlers directly ramp each frame. Inv_LenkRadius was already correctly wrapped here, just undocumented, so this only adds doc comments cross- referencing the two - Lenkhebel is left unchanged in case some other OmsiMovingMapObjInst subtype genuinely uses that offset.