Skip to content

fix: reconcile separately mounted SQLite plugin trees - #30

Merged
soulteary merged 2 commits into
mainfrom
fix/mounted-plugin-reconcile
Aug 30, 2026
Merged

soulteary merged 2 commits into
mainfrom
fix/mounted-plugin-reconcile

Conversation

@soulteary

Copy link
Copy Markdown
Owner

Summary

  • keep the atomic rename path for ordinary managed plugin directories
  • fall back to an in-place, backup-backed reconciliation when a separately mounted destination cannot be renamed
  • persist a marker so an interrupted in-place update restores the previous contents before retrying
  • replace matching destination symlinks instead of allowing diff to dereference and retain them
  • use unique staging directories while preserving the managed source directory mode
  • fix the test assertion so it detects the child entrypoint's staging name instead of using the parent test PID

Tests

bash tests/test-entrypoint-reconcile.sh now covers:

  • ordinary replacement and removal of upstream-deleted files
  • a matching symlink target
  • simulated mount-point EBUSY while preserving the destination inode
  • interrupted in-place recovery
  • wildcard staging/rollback artifact cleanup assertions

Also checked both shell files with bash -n and ran git diff --check.

Follow-up to the entrypoint review in #10.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T20:06:47.527197Z 8dc2f81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soulteary
soulteary force-pushed the fix/mounted-plugin-reconcile branch from 8dc2f81 to a5e1c46 Compare August 30, 2026 20:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dc2f819e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docker-entrypoint-sqlite.sh Outdated
@soulteary
soulteary merged commit 1372829 into main Aug 30, 2026
4 checks passed
@soulteary
soulteary deleted the fix/mounted-plugin-reconcile branch September 3, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant