Skip to content

fix: reject Unicode whitespace in recovery URLs - #29

Merged
soulteary merged 1 commit into
mainfrom
fix/unicode-url-whitespace
Aug 30, 2026
Merged

soulteary merged 1 commit into
mainfrom
fix/unicode-url-whitespace

Conversation

@soulteary

Copy link
Copy Markdown
Owner

Summary

  • reject malformed UTF-8 before URL parsing
  • reject Unicode separator characters and U+0085 in addition to the existing ASCII whitespace/control range
  • retain valid UTF-8 path support instead of banning non-ASCII input wholesale
  • add cases for NBSP, NEL, em space, line separator, paragraph separator, invalid UTF-8, and a valid Unicode path

Validation

  • git diff --check
  • the existing PHP test suite will execute the new cases in CI

Follow-up to the recovery URL validation review in #22.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T20:06:15.015598Z 2e60da8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soulteary
soulteary merged commit fce6af7 into main Aug 30, 2026
4 checks passed
@soulteary
soulteary deleted the fix/unicode-url-whitespace branch September 3, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant