Implement API quality & reliability improvements - #1661
Merged
hman38705 merged 1 commit intoSep 28, 2026
Merged
Conversation
- solutions-plug#1519: Dead-letter queue requeue idempotency enforcement * RequeueResult enum distinguishes NotFound vs NotInDeadLetter * Handler returns 409 CONFLICT for status mismatch (not silent success) * Data layer idempotent independent of HTTP cache TTL * Test confirms no duplicate sends on double-requeue - solutions-plug#1520: API error variants to OpenAPI schema mapping contract test * Enumerates all ApiError variants and required schemas * Contract test fails if new variant added without documentation * Prevents undocumented error responses to clients * Current coverage: 6 error variants (400/404/409/429/500/503) - solutions-plug#1521: Bounded in-memory watched_txs restore on startup * Max restore limit: 50,000 transactions * Warning logged when table exceeds bound * Startup metric tracks watched_tx_count * Prevents memory exhaustion on large tables - solutions-plug#1522: Pagination mutual exclusivity (offset vs cursor) * Validates offset and cursor are mutually exclusive * Returns 400 BAD_REQUEST with clear error message * Unit tests cover all four parameter combinations * API docs clarify pagination strategy separation Closes solutions-plug#1519 solutions-plug#1520 solutions-plug#1521 solutions-plug#1522 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014jDDop7frnew1xcCJDSKEw
|
@katefominmoore23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirm dead-letter queue requeue endpoint enforces idempotency for double-requeue #1519: Dead-letter queue requeue idempotency enforcement
Add contract test ensuring handlers.rs ApiError variants map to documented OpenAPI error schemas #1520: API error variants to OpenAPI schema mapping contract test
Bound in-memory watched_txs restore on startup for very large tx-watch tables #1521: Bounded in-memory watched_txs restore on startup
Add negative-path tests for pagination.rs offset+cursor combined usage #1522: Pagination mutual exclusivity (offset vs cursor)
Closes #1519
Closes #1520
Closes #1521
Closes #1522
Claude-Session: https://claude.ai/code/session_014jDDop7frnew1xcCJDSKEw
Description
Type of Change
Testing Done
Bundle Size
Checklist
docs/architecture.mdRelated Issues
Closes #