fix: address #1554, #1555, #1556, #1561 - #1657
Merged
hman38705 merged 5 commits intoSep 27, 2026
Merged
Conversation
…red in, would be Closes solutions-plug#1554
…t README link — b Closes solutions-plug#1555
…/runbooks/ or doc Closes solutions-plug#1556
…ocales not presen Closes solutions-plug#1561
|
@only1dreamgene Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…6-1561 # Conflicts: # contracts/predict-iq/src/modules/oracles.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #1554, #1555, #1556, #1561
What was solved
#1554 — verify_oracle_health is dead code and, if wired in, would be a misleadingly weak health check
Wire a genuinely useful oracle health check into market-creation validation so malformed feed_ids are rejected up front, and add a test proving market creation fails for a malformed feed_id rather than only at resolution time.
Addressed:
verify_oracle_healthbut make it meaningful: validate the feed_id decodes correctly (e.g. viadecode_feed_id) instead of only checking non-emptiness.#1555 — Fix docs/README.md structure diagram and root README link — both stale
Update docs/README.md so its directory tree lists every file/subdirectory currently present in docs/ (API_SPEC.md, CONTRACT_ERRORS.md, api-versioning.md, architecture.md, data-flow.md, deployment.md, secrets.md, runbooks/, pr/, plus existing README.md and DISTRIBUTED_TRACING.md), and fix the stale root README link on line 18 so it resolves to an existing file.
Addressed:
#1556 — docs/README.md has no index entries for docs/runbooks/ or docs/pr/
Update docs/README.md to add an "Operations / Runbooks" category that links to docs/runbooks/ (or an index within it), and add a short note clarifying the purpose and retention policy of docs/pr/ and frontend/docs/pr/ working notes. This is a documentation-only, index/discoverability fix scoped to the docs index.
Addressed:
#1561 — frontend/I18N_GUIDE.md advertises es/fr/de locales not present in frontend/src/lib/i18n.ts
Update frontend/I18N_GUIDE.md so its supported-locale list matches the actual translations defined in frontend/src/lib/i18n.ts (only
en), and clearly mark es/fr/de as planned/not yet implemented with a follow-up note for tracking translation work.Addressed:
en).Changes
contracts/predict-iq/src/modules/oracles.rs(modify)docs/README.md(modify)frontend/I18N_GUIDE.md(modify)Approach
Issues
Closes #1554
Closes #1555
Closes #1556
Closes #1561