Merged
Conversation
We want to write into the `test.log` instead, which rspec/rails already set up for us.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6268 +/- ##
==========================================
- Coverage 88.82% 88.82% -0.01%
==========================================
Files 851 851
Lines 18349 18348 -1
==========================================
- Hits 16299 16298 -1
Misses 2050 2050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for this find! |
adammathys
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Due to a change in #6244 we now log to stdout in tests, instead of to the
test.logfile. This clutters test output on CircleCIhttps://app.circleci.com/pipelines/github/solidusio/solidus/8111/workflows/1ccfe0fe-1905-4145-9d50-8af1c93f258b/jobs/80080/parallel-runs/0/steps/0-112
Instead we just let Rails / RSpec do their default logging.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: