Open
Conversation
We want to support Solidus 4. Also add some gems that are missing for Solidus 4 functionality. And fixed the circle ci config to run tests successfully. Since main can go beyond v4.5 I locked it in.
- Update method name from order_finalized to send_confirmation_email - Change target class from Spree::MailerSubscriber to Spree::OrderMailerSubscriber - Remove version conditional since gem now only supports Solidus 4+
No longer required with Solidus 4+. The method it is overriding doesn't exist anymore.
Error: unrecognized cop or department RSpec/NestedGroups found in .rubocop.yml unrecognized cop or department RSpec/MessageSpies found in .rubocop.yml Exited with code exit status 2
- Add the requirement of open struct now that it isn't automatically included - Change expectations to account for changes with how state changes are handled in background jobs. solidusio/solidus@2a2df71 - Replace build_stubbed with just build, some objects were missing fields - Since we removed the requirement for solidus_frontend from this gem, we don't care about the reset password email sending so we can just stub it out
NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger
Logger::Severity.constants.each do |severity|
^^^^^^
To fix 'stack level too deep' error.
Similar to the confirm email, we need this to respect the 'disable_builtin_emails' value.
The Circle.ci Orb relies on this environment variable for switching the Solidus version, so we need to match that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR to test running tests on Circle against newer versions of Solidus.
PLEASE DO NOT MERGE