Skip to content

fix: require vite 8 newer - #2187

Merged
birkskyum merged 7 commits into
mainfrom
vite-8-only
Jul 16, 2026
Merged

birkskyum merged 7 commits into
mainfrom
vite-8-only

Conversation

@birkskyum

@birkskyum birkskyum commented Jul 16, 2026 •

Copy link
Copy Markdown
Member

Rolldown is Stable, Vite 8 is Stable.

Being able to assume vite 8+ makes it easier to maintain this library, because we cut out the entire rollup/esbuild dance, and because of it's strong rollup plugin backwards compat there's a clear migration path.

Running vite build will show

❯ pnpm run build
$ vite build
[@solidjs/vite-plugin-nitro-2] This plugin is deprecated. Migrate to Nitro v3 using the official `nitro/vite` plugin. See https://github.com/solidjs/templates/tree/main/solid-start-v2 for examples.
vite v8.1.4 building client environment for production...
✓ 14 modules transformed.
computing gzip size...

@changeset-bot

changeset-bot Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29074da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 29074da
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a58541d0607cc0008173e3d
😎 Deploy Preview https://deploy-preview-2187--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@birkskyum
birkskyum requested review from katywings and lxsmnsyc July 16, 2026 02:01
@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2187
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2187

commit: 29074da

@lxsmnsyc

lxsmnsyc commented Jul 16, 2026 •

Copy link
Copy Markdown
Member

I think we should lock it Vite 8 first no? are we not expecting some big changes

@birkskyum

birkskyum commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

I think we should lock it Vite 8 first no? are we not expecting some big changes

I don't understnd - this does exactly that, lock it to vite 8 and up. Which big changes do you have in mind?

@lxsmnsyc

Copy link
Copy Markdown
Member

@birkskyum the version range applies to 9 and above, which is what I'm concerned about.

@birkskyum

birkskyum commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

Okay, I've set it vite 8 only

@birkskyum

birkskyum commented Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

I can follow up with a dedicated vite 9 forward compat pr, so Start v2 has some runway.

@birkskyum
birkskyum merged commit 3e961e0 into main Jul 16, 2026
10 checks passed
@birkskyum
birkskyum deleted the vite-8-only branch July 16, 2026 03:58
huseeiin pushed a commit to huseeiin/solid-start that referenced this pull request Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants