Repository navigation
fix: require vite 8 newer - #2187
Conversation
🦋 Changeset detectedLatest commit: 29074da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
I think we should lock it Vite 8 first no? are we not expecting some big changes |
I don't understnd - this does exactly that, lock it to vite 8 and up. Which big changes do you have in mind? |
|
@birkskyum the version range applies to 9 and above, which is what I'm concerned about. |
|
Okay, I've set it vite 8 only |
|
I can follow up with a dedicated vite 9 forward compat pr, so Start v2 has some runway. |
Rolldown is Stable, Vite 8 is Stable.
Being able to assume vite 8+ makes it easier to maintain this library, because we cut out the entire rollup/esbuild dance, and because of it's strong rollup plugin backwards compat there's a clear migration path.
Running vite build will show