Skip to content

fix: URL to path conversion in manifest resolver#2141

Open
silen-z wants to merge 2 commits intosolidjs:mainfrom
silen-z:main
Open

fix: URL to path conversion in manifest resolver#2141
silen-z wants to merge 2 commits intosolidjs:mainfrom
silen-z:main

Conversation

@silen-z
Copy link
Copy Markdown

@silen-z silen-z commented Apr 23, 2026

What is the current behavior?

Resolving of virtual module solid-start:get-manifest fails when path contains spaces.

What is the new behavior?

Path gets converted and resolved correctly even when it contains spaces.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 8ee4853
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69fcddbc469412000764e206
😎 Deploy Preview https://deploy-preview-2141--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Latest commit: 8ee4853

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 23, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2141
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2141

commit: 8ee4853

@brenelz
Copy link
Copy Markdown
Contributor

brenelz commented May 6, 2026

Could you please add a changeset. Also if possible add some tests for this?

@silen-z
Copy link
Copy Markdown
Author

silen-z commented May 7, 2026

Added changeset.

I'm not sure how to write a test for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot find module 'solid-start:get-manifest'

2 participants