Repository navigation
fix(api): let a HEAD served by a declining GET fall through like GET - #31
Merged
Merged
Conversation
Fixes #19 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtVqG6fjQyZv5ZnEFKdcyK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Fixes #19
createAPIHandleranswersHEADwith the module'sGETexport, but only aGETrequest was allowed to decline (returnundefined). AHEADanswered by a decliningGETthrew "did not return a response", which apps turn into a 500. So a page with a conditionalGET(canonical redirects and the like) answered200toGETand500toHEAD.The decline check now accepts
HEADas well: a page falls through to the chain (the server drops the body), and a handler-only route answers 404, the same asGET. This is the fix @frenzzy suggested in the issue, with their test.test/api.spec.tscovers the page and handler-only cases; it fails onmain.pnpm testpasses (114). It also merges cleanly with fix(api): let createAPIHandler take the request event #22 and the other open fixes (132 tests on the combined branch).Generated by Claude Code