Skip to content

fix(client): proper encoding and data for account notifications#163

Open
pcbzzz wants to merge 1 commit intosolana-foundation:mainfrom
pcbzzz:fix/ws-base64
Open

fix(client): proper encoding and data for account notifications#163
pcbzzz wants to merge 1 commit intosolana-foundation:mainfrom
pcbzzz:fix/ws-base64

Conversation

@pcbzzz
Copy link
Copy Markdown

@pcbzzz pcbzzz commented Mar 7, 2026

Summary

@solana/client doesn't request base64 encoding for handleAccountNotifications even though it does for fetchAccount, so the account gets updated with data that is either base58 or an error about the account being too large for base58. The watcher also updates the account cache entry with .data which changes account.data from Base64EncodedRpcAccount to Base64EncodedDataResponse

I wasn't sure if this needed a changeset since it seems like a bug

Testing

  • pnpm lint
  • pnpm test
  • pnpm build
  • Other (describe): I have been using a patched version of the library and useAccount is no longer returning a base58 error for large accounts, and updated data is correct without workarounds

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 7, 2026

@pcbzzz is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant