fix(client): proper encoding and data for account notifications#163
Open
pcbzzz wants to merge 1 commit intosolana-foundation:mainfrom
Open
fix(client): proper encoding and data for account notifications#163pcbzzz wants to merge 1 commit intosolana-foundation:mainfrom
pcbzzz wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
|
@pcbzzz is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solana/clientdoesn't request base64 encoding forhandleAccountNotificationseven though it does forfetchAccount, so the account gets updated with data that is either base58 or an error about the account being too large for base58. The watcher also updates the account cache entry with.datawhich changesaccount.datafromBase64EncodedRpcAccounttoBase64EncodedDataResponseI wasn't sure if this needed a changeset since it seems like a bug
Testing
pnpm lintpnpm testpnpm builduseAccountis no longer returning a base58 error for large accounts, and updated data is correct without workarounds