chore(ci): add a CI-Result gate and the merge_group trigger - #1365
Merged
Woody4618 merged 2 commits intoOct 1, 2026
Merged
Conversation
|
@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
A merge queue needs a required check, and upstream master requires none. CI-Result fails when any CI job fails, and its name does not change with the Node version or the shard count.
A skipped Build-Info passes CI-Result, so a queued commit could merge with a bench/BUILD.md that does not match the combined build.
askov
force-pushed
the
chore/ci-merge-queue
branch
from
October 1, 2026 09:52
62325aa to
b8b8c7a
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Woody4618
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
CI-Resultjob that a merge queue can require, and runs CI on merge-queue commits.Changes
merge_grouptrigger toci.yaml, so CI runs on the commits a merge queue builds.CI-Resultjob that fails when a job in itsneedsfails or is cancelled.Build-Infoon merge-queue commits, so the combined build must matchbench/BUILD.md.Storybook-Smoke-Testsout ofCI-Result, so itscontinue-on-errorsetting still applies.Behavior Changes
CI / CI-Resultcheck, red whenBuild-And-Test,Specs-Shards,Build-Info,Security-AuditorSitemap-Checkis red.One gate job
The matrix jobs carry the Node version and the shard number in their names, such as
Build-And-Test (22)andSpecs-Shards (24.x, 2). A ruleset that requires those names blocks every PR after a.nvmrcbump.CI-Resultkeeps one name, and itsneedslist decides what blocks a merge.Type of change
Screenshots
Not a UI change.
Testing
exit 1step toSitemap-Check. ExpectSitemap-CheckandCI-Resultboth to fail.if: always(), a failed job skips the gate. Fork run also removesif: always(). ExpectCI-Resultto show as skipped, which a required check counts as passed.Related Issues
Part of HOO-1838
Checklist
pnpm test,pnpm lint,pnpm typecheck)build:infoscript to update build informationAdditional Notes
After this merges, a repository admin adds a new branch ruleset for the default branch, with "Require status checks to pass" (
CI-Resultfrom GitHub Actions) and "Require merge queue" (squash). The existingmasterruleset is an organization ruleset, so it stays unchanged.