Repository navigation
Curl backend: cancel the request when the sending thread is interrupted - #3049
Merged
Merged
Conversation
# Conflicts: # core/src/main/scalanative/sttp/client4/curl/AbstractCurlBackend.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3043 (point 3).
Interrupting the thread that sends a request had no effect: the request ran until it completed.
Now the transfer is driven with curl's multi interface, waiting for at most 100ms at a time. Between the waits, the thread's interrupted flag is checked; if set, the transfer is stopped and an
InterruptedExceptionis thrown. The same check is done in the streaming response path, both while waiting for the headers and while reading the body.As an interrupted (or otherwise failed) request now ends early, the curl handle, response buffers and output file are released on every exit, not only on success. Downloading to a file that can't be opened now fails, instead of writing the body to stdout.
Added native tests, named as
HttpTest's cancel tests, which interrupt a thread waiting for a response, and one receiving a slow response body (default and streaming path).