Repository navigation
Curl backend: send and receive binary bodies correctly - #3047
Merged
Merged
Conversation
The request body options were set in a discarded effect, so with cats-effect and ZIO the body was never sent, and curl read it from stdin. The new shared non-UTF-8 test also showed that the HttpClient backends sent string bodies as UTF-8, ignoring their encoding.
# Conflicts: # core/src/main/scalanative/sttp/client4/curl/AbstractCurlBackend.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3043 (point 1).
Request bodies were turned into a
Stringand then into a C string. Bytes that are not valid UTF-8 were changed, and the body was cut at the first NUL byte. As theContent-Lengthheader still had the original size, the server kept waiting for the rest of the body, and the request timed out.Response bodies had the same problem: they were read with
fromCString.Now:
Also fixed in the
HttpClientbackends (found by the new shared test): string bodies were always sent as UTF-8, ignoring their encoding, whileContent-Lengthused the declared encoding.Tests (shared
HttpTest, mirrored in the nativeSyncHttpTest):