[Android] Fix basic-example hermesc path - #4371
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Android build configuration for the basic example now resolves the Hermes compiler from the standalone ChangesHermes compiler configuration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Pull request overview
Fixes Android release builds of the basic-example app by updating the configured Hermes compiler path to a repo-relative, OS-aware location compatible with React Native’s %OS-BIN% substitution logic.
Changes:
- Update
react { hermesCommand = ... }to point atnode_modules/hermes-compiler/...with%OS-BIN%placeholder for OS-specific bin selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* Hermes Commands */ | ||
| // The hermes compiler command to run. By default it is 'hermesc' | ||
| hermesCommand = "../../../../node_modules/react-native/sdks/hermesc/osx-bin/hermesc" | ||
| hermesCommand = "../../node_modules/hermes-compiler/hermesc/%OS-BIN%/hermesc" |
There was a problem hiding this comment.
I changed to OS-BIN so Linux also works (CI). I don't think we care about Windows in this case.
Description
I've noticed that release builds of basic example fail on android due to the wrong path of hermesc set.
hermescpath is resolved with the working dir set to the app directory and React Native will automatically select the right OS-specific path.Test plan
Build the app in release mode or run
./gradlew :app:createBundleReleaseJsAndAssetsbefore & after this change.