Skip to content

[Android] Fix basic-example hermesc path - #4371

Merged
j-piasecki merged 1 commit into
mainfrom
jpiasecki/fix-hermesc-path-basic-example
Aug 4, 2026
Merged

[Android] Fix basic-example hermesc path#4371
j-piasecki merged 1 commit into
mainfrom
jpiasecki/fix-hermesc-path-basic-example

Conversation

@j-piasecki

Copy link
Copy Markdown
Member

Description

I've noticed that release builds of basic example fail on android due to the wrong path of hermesc set.

hermesc path is resolved with the working dir set to the app directory and React Native will automatically select the right OS-specific path.

Test plan

Build the app in release mode or run ./gradlew :app:createBundleReleaseJsAndAssets before & after this change.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 340ca06e-4a94-485d-bec1-b87d164bdde2

📥 Commits

Reviewing files that changed from the base of the PR and between f0c98c7 and 779b5e1.

📒 Files selected for processing (1)
  • apps/basic-example/android/app/build.gradle

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the Android build configuration to use the standalone Hermes compiler package, improving compatibility with the current build setup.

Walkthrough

The Android build configuration for the basic example now resolves the Hermes compiler from the standalone hermes-compiler package.

Changes

Hermes compiler configuration

Layer / File(s) Summary
Update Hermes compiler resolution
apps/basic-example/android/app/build.gradle
The Hermes compiler command now uses the standalone hermes-compiler package instead of React Native’s bundled sdks/hermesc path.

Suggested reviewers: m-bert, copilot

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Android basic example and the hermesc path fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Android release builds of the basic-example app by updating the configured Hermes compiler path to a repo-relative, OS-aware location compatible with React Native’s %OS-BIN% substitution logic.

Changes:

  • Update react { hermesCommand = ... } to point at node_modules/hermes-compiler/... with %OS-BIN% placeholder for OS-specific bin selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

/* Hermes Commands */
// The hermes compiler command to run. By default it is 'hermesc'
hermesCommand = "../../../../node_modules/react-native/sdks/hermesc/osx-bin/hermesc"
hermesCommand = "../../node_modules/hermes-compiler/hermesc/%OS-BIN%/hermesc"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to OS-BIN so Linux also works (CI). I don't think we care about Windows in this case.

@j-piasecki
j-piasecki merged commit 35a0aea into main Aug 4, 2026
4 checks passed
@j-piasecki
j-piasecki deleted the jpiasecki/fix-hermesc-path-basic-example branch August 4, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants