[SofaImplicitField] add vectorized scalarfield binding#5673
Open
damienmarchal wants to merge 27 commits intosofa-framework:masterfrom
Open
[SofaImplicitField] add vectorized scalarfield binding#5673damienmarchal wants to merge 27 commits intosofa-framework:masterfrom
damienmarchal wants to merge 27 commits intosofa-framework:masterfrom
Conversation
damienmarchal
added
pr: enhancement
damienmarchal
changed the title
…urface-mesh # Conflicts: # applications/plugins/SofaImplicitField/examples/python/python-scalarfield.py # applications/plugins/SofaImplicitField/python/src/Binding_ScalarField.cpp
When the name is passed by key,value it is not set.
damienmarchal
force-pushed
the
pr-add-vectorized-scalarfield-binding
branch
from
f6a9bf8 to
1ec59f7
Compare
damienmarchal
force-pushed
the
pr-add-vectorized-scalarfield-binding
branch
from
1ec59f7 to
e966ddd
Compare
Contributor
Author
|
Small benchmark (benchmark_implicit.py): meshing spherical field function using a grid with a 200x200x200 rsolution took: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of the work on SofaImplicitField.
In PR #5559 we add python binding to ScalarField, so we can implement a scalar field in python
In PR #5565 we add a component class FieldToSurfaceMesh to mesh any Scalar Field using marching cube
In PR #5672 we add asynchronous computation to the component FieldToSurfaceMesh
In the present PR we add vectorized version of ScalarField::getValue so it can process chunk of field evaluation.
Typically the kind of workload/pattern that happens when using ScalarFields for collision, rendering with raymarching or meshing.
Using the vectorized API has big consequences in term of performances especially when the field is implemented in python or using a cuda implementation on GPU.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if