[Framework] Apply template method design pattern to CollisionModel#5481
Open
lbinria wants to merge 4 commits intosofa-framework:masterfrom
Open
[Framework] Apply template method design pattern to CollisionModel#5481lbinria wants to merge 4 commits intosofa-framework:masterfrom
lbinria wants to merge 4 commits intosofa-framework:masterfrom
Conversation
lbinria
added
pr: breaking
Author
|
[ci-build][with-all-tests] |
bakpaul
force-pushed
the
2025_sprintsed_CollisionModel
branch
from
5b3c4dc to
ef2c039
Compare
bakpaul
added a commit
to lbinria/sofa
that referenced
this pull request
Jan 6, 2026
…o account Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
bakpaul
added a commit
to lbinria/sofa
that referenced
this pull request
Jan 6, 2026
…o account Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
bakpaul
force-pushed
the
2025_sprintsed_CollisionModel
branch
from
ef2c039 to
c02307a
Compare
bakpaul
added
pr: status to review
…o account Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
bakpaul
force-pushed
the
2025_sprintsed_CollisionModel
branch
from
c02307a to
070718d
Compare
Collaborator
|
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
hugtalbot
reviewed
Apr 8, 2026
Sofa/Component/Collision/Geometry/src/sofa/component/collision/geometry/PointCollisionModel.h
Outdated
Show resolved
Hide resolved
...gins/SofaDistanceGrid/src/SofaDistanceGrid/components/collision/DistanceGridCollisionModel.h
Outdated
Show resolved
Hide resolved
Collaborator
|
[ci-depends-on] detected during build #8. To unlock the merge button, you must
|
bakpaul
added a commit
that referenced
this pull request
Apr 8, 2026
commit 68251eb Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 16:51:03 2026 +0200 Apply reviews commit a5e0a9e Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 15:29:18 2026 +0200 Fig distance grid commit bb0c921 Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 11:35:50 2026 +0200 Fix compilationa fter merge commit 070718d Author: Paul Baksic <paul.baksic@outlook.fr> Date: Tue Jan 6 10:50:31 2026 +0100 Apply modified patch from #5481 to take refactoring into account Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
bakpaul
added a commit
that referenced
this pull request
Apr 8, 2026
commit 68251eb Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 16:51:03 2026 +0200 Apply reviews commit a5e0a9e Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 15:29:18 2026 +0200 Fig distance grid commit bb0c921 Author: Paul Baksic <paul.baksic@outlook.fr> Date: Wed Apr 8 11:35:50 2026 +0200 Fix compilationa fter merge commit 070718d Author: Paul Baksic <paul.baksic@outlook.fr> Date: Tue Jan 6 10:50:31 2026 +0100 Apply modified patch from #5481 to take refactoring into account Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
bakpaul
added
pr: status wip
bakpaul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ci-depends-on https://github.com/sofa-framework/SofaSphFluid/pull/20]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if