[CMake] ADD option to fetch pull-request commits in ExternalProject#1961
Merged
jnbrunet merged 6 commits intosofa-framework:masterfrom May 21, 2021
Merged
Conversation
guparan
added
the
pr: status wip
guparan
added
pr: status to review
guparan
added
pr: status to review
Contributor
Author
|
[ci-build] |
…ernalproject_options # Conflicts: # applications/plugins/SofaPython3/ExternalProjectConfig.cmake.in
Collaborator
|
[ci-depends-on] detected during build #54. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
hugtalbot
added
pr: status wip
Contributor
|
See discussion here |
Collaborator
|
[ci-depends-on] detected during build #59. To unlock the merge button, you must
|
guparan
added
pr: enhancement
hugtalbot
added
pr: status ready
Contributor
Author
|
[ci-build] |
1 similar comment
Contributor
Author
|
[ci-build] |
Collaborator
|
[ci-depends-on] detected during build #62. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
Contributor
|
What's up with the CI? Build failed on centos and ubuntu? |
Contributor
Author
A weird error that happens sometimes... I relaunched and it's OK now. |
guparan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When your SOFA PR fails on CI somewhere in an external project, it may be because your change is breaking for that external project.
In that case, the best (and preferred) solution is that you push a fix in the external project so that when your PR is merged in SOFA, it does not fail on CI.
Here is the typical workflow for that use case.
[ci-depends-on https://github.com/<org>/<repo>/pull/<id>]This way, you do not need to touch any
ExternalProject.cmakefile in your SOFA PR 👍The only change in this PR consists in adding
GIT_CONFIG "remote.origin.fetch=+refs/pull/*:refs/remotes/origin/pr/*"to all ExternalProject.cmake files.This change permits to have access to any commit in any pull-request (including merge commits). See this nice cheatsheet about how to fetch PRs.
All other changes have been done in CI scripts and are ready to use.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if