[bindings] Started Topology and BaseMeshTopology bindings#114
Merged
jnbrunet merged 1 commit intosofa-framework:masterfrom Feb 18, 2021
psomers3:master
Merged
[bindings] Started Topology and BaseMeshTopology bindings#114jnbrunet merged 1 commit intosofa-framework:masterfrom psomers3:master
jnbrunet merged 1 commit intosofa-framework:masterfrom
psomers3:master
Conversation
Contributor
|
Hey @psomers3 , Indeed, this is a much better fix !
No one has. It won't be possible to bind every properties or methods for every SOFA components. But at some point, if more people come in and add the bindings they need, we will get a not so bad coverage. By adding these python components, you just made this task easier, while fixing your issue, so very nice :) +1 for me @hugtalbot @fredroy @guparan did one of you guys wanted to take a quick look? |
Contributor
|
Looks fine to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this is a better way to fix #113. I don't have the time right now to fill the objects with their class-specific properties/methods, but the groundwork is now there for someone to add them as needed.
The following now works in a python forcefield: