Fix perturbation assay names with invalid characters#23
Open
rootze wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.sanitize_perturbation_name()is for creating perturbation assays. It takes the user-provided name, checks that it is valid input, converts it to a safe R/Seurat-style name with make.names(), and warns if the name changed. It is used near the start of.resolve_perturbation_assay_name()is for finding perturbation assays that may already exist.It checks: Does the exact name exist in seurat_obj@assays? If not, does the sanitized version exist? If neither exists, return the original name so the normal error message can say it was not found.