Open
Conversation
Manually shims NProgress wraps the NProgress lib in the support `fastboot-transform` lib Changes the required way to import this lib as `import nprogress from 'nprogress';` instead of `import nprogress from 'ember-cli-nprogress';` as it was previous. Updates README.md with the proper way to import this lib Ensures that the NProgress lib does not init in fastboot land, but also ensures that initializer from the consuming app will still have something to import 'nprogress' from.
Author
|
NOTE! This changes how people will be importing Fixes #7 |
Author
|
@smashweaver How do you feel about this one ^? Would love to get this merged and point my project back at the latest release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually shims NProgress
wraps the NProgress lib in the support
fastboot-transformlibChanges the required way to import this lib as
import nprogress from 'nprogress';instead ofimport nprogress from 'ember-cli-nprogress';as it was previous.Updates README.md with the proper way to import this lib
Ensures that the NProgress lib does not init in fastboot land, but also ensures that initializer from the consuming app will still have something to import 'nprogress' from.