feat(confidentialhttp): align AuthConfig SDK with new proto shape#248
Draft
feat(confidentialhttp): align AuthConfig SDK with new proto shape#248
Conversation
Adds AuthConfigInput discriminated union + buildAuthConfig factory for the confidentialHTTP capability. Covers all signing methods landed in chainlink-protos: ApiKey, Basic, Bearer, HMAC-SHA256, AWS SigV4, custom HMAC, OAuth2 client_credentials, OAuth2 refresh_token. // remove before merge: submodule dirty — will be bumped to chainlink-protos HEAD
…mps submodules/chainlink-protos to rtinianov_signedExpansion (afc1fef0), regenerates protos and SDK against the new schema, and rewrites buildAuthConfig for the new field shape (secret_name string -> secret SecretIdentifier, plus StringOrSecret for fields that can be public or secret). buildAuthConfig() now returns AuthConfigJson so callers can drop it straight into ConfidentialHTTPRequestJson.auth literals. Updates src/sdk/cre/__tests__/confidentialhttp.test.ts to match. 10/10 pass. Verified end-to-end via cre workflow simulate against chainlink-common@rtinianov_signingExpansion: a workflow exercising apiKey, apiKey-with-prefix, basic, bearer, bearer-with-custom-prefix, hmacSha256, hmacCustom-SHA512, oauth2 client_credentials, oauth2 refresh_token round-trips with the expected signed headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
against the new schema.
StringOrSecret where the field can carry a plain value). buildAuthConfig() now returns AuthConfigJson so callers can drop it straight into a
ConfidentialHTTPRequestJson.auth literal.
Why
The chainlink-protos@rtinianov_signedExpansion proto refactor (secret_name string -> secret SecretIdentifier, plus StringOrSecret for fields
that can be public or secret) is wire-incompatible with the older shape. cre-sdk-typescript@signingExpansion was still on the old shape, so
any TS workflow targeting chainlink-common@rtinianov_signingExpansion failed simulator-side with 'proto: cannot parse invalid wire-format
data'. This brings TS into line.
Test plan
Follow-ups
Tighten it.