feat: added slo duplicates check during validate #799
Merged
Conversation
r3code
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 30.84% 30.79% -0.05%
==========================================
Files 141 141
Lines 8689 8703 +14
==========================================
Hits 2680 2680
- Misses 5770 5784 +14
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
r3code
force-pushed
the
add-slo-duplicate-validation
branch
3 times, most recently
from
5c86cae to
9023c71
Compare
r3code
changed the title
Signed-off-by: Dmitriy S. Sinyavskiy <contact@r3code.ru>
r3code
force-pushed
the
add-slo-duplicate-validation
branch
from
9023c71 to
e4dcef5
Compare
Contributor
Author
|
Awesome! Thanks man for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds checks for SLO duplicates into sloth validate command.
Enabled by default.
To disable use --ignore-slo-duplicates=true param.
Closes #493