feat: add helm documentation and modernize Chart.yaml#706
feat: add helm documentation and modernize Chart.yaml#706standardloop wants to merge 2 commits intoslok:mainfrom
Conversation
|
Open to feedback on how we want to integrate updating docs into the release process. Please let me know! |
bef977c to
931fbaa
Compare
|
merge conflicts have been fixed |
|
Hi @standardloop, thanks for the contribution. Could you help me understanding this documentation, as it seems to me redundant to checking the |
Are you asking why have a README for the helm chart in the repo instead of on the website here: I just opened an MR that renders with README on the website: The README of the helm chart should be the source of truth and all other places should be rendering it.Doc websitesHere is an example with a different application One finds the documentaion: And the chart section is just rendering the same README from the github chart Here is there code to do that: The README is also the same as the one on artifact hub is rendering: Current flowThere is no helm chart README so no refernces (artifact hub, docs website) can render it I typically use Artifact Hub to know what version is up to date and what the values for a chart. Looks like a different account uploads your charts. I used that link before, but there was no documenation on the page, it is blank. I also noticed on your website there isn't too much documenation on the chart values itself. |
|
@slok any update on this one? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
Goal
This PR aims to improve following
Give an appVersion to Chart.yaml
When installing the chart as it is now, the following is shown with a
helm listThe appVersion section is missing
Create a helm README and autogenerate docs
There is currently no README for helm, these are helpful to see what values can be passed and how to install the chart.
This MR autogenerates the README using helm-docs by creating
README.md.gotmpland adding a Makefile command to runhelm-docsrender it. This is the standard across many helm tools.Misc Changes
In
Chart.yamlchangehometo be website homepage and addsourcesto link to the github repo