Repository navigation
fix(web-api): accept enterprise in assistant.search.context content_types - #2875
Conversation
…ypes Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 5563b16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 94.48% 94.54% +0.05%
==========================================
Files 68 68
Lines 10942 10942
Branches 696 693 -3
==========================================
+ Hits 10339 10345 +6
+ Misses 574 571 -3
+ Partials 29 26 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
🧩 Thanks @zimeg! Matching the arguments to the reference order makes this so much easier to check against the docs page.
Left a couple of comments, nothing blocking 🙏
…t_types description Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
left a comment
There was a problem hiding this comment.
📚 Thanks @zimeg! The hover text now matches the union, so enterprise shows up where folks look first.
The SortDir suggestion from before is still optional, nothing blocking 💯
…xt sort_dir Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
🌟 Thanks for the kind reviews @mwbrooks @cchensh and @WilliamBergamin! |
Summary
This pull request matches the
assistant.search.contextarguments from #2613 to the reference page.content_typesacceptsenterprise, one of the acceptable values on the reference page.Testing
npm run test:types --workspace=packages/web-apipasses theassistant.search.contextchecks, withenterprisein the happy path. The 6 failures infiles.test-d.tsandrtm.test-d.tsare onmaintoo.content_types: ['messages', 'enterprise']andsort_dir: 'asc'returnokfrom a live workspace.Requirements
🤖 Generated with Claude Code