Skip to content

fix(web-api): accept enterprise in assistant.search.context content_types - #2875

Merged
zimeg merged 3 commits into
mainfrom
zimeg-fix-assistant-search-context-arguments
Nov 20, 2026
Merged

zimeg merged 3 commits into
mainfrom
zimeg-fix-assistant-search-context-arguments

Conversation

@zimeg

@zimeg zimeg commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request matches the assistant.search.context arguments from #2613 to the reference page.

  • content_types accepts enterprise, one of the acceptable values on the reference page.
  • The arguments are listed in the order of the reference page's Arguments list.
  • Adds a patch changeset.

Testing

  • npm run test:types --workspace=packages/web-api passes the assistant.search.context checks, with enterprise in the happy path. The 6 failures in files.test-d.ts and rtm.test-d.ts are on main too.
  • With a local build, content_types: ['messages', 'enterprise'] and sort_dir: 'asc' return ok from a live workspace.

Requirements

🤖 Generated with Claude Code

…ypes

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 19, 2026 04:39
@zimeg zimeg added this to the web-api@next milestone Nov 19, 2026
@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Nov 19, 2026
@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5563b16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@slack/web-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zimeg zimeg self-assigned this Nov 19, 2026
@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.54%. Comparing base (881ca7b) to head (5563b16).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
+ Coverage   94.48%   94.54%   +0.05%     
==========================================
  Files          68       68              
  Lines       10942    10942              
  Branches      696      693       -3     
==========================================
+ Hits        10339    10345       +6     
+ Misses        574      571       -3     
+ Partials       29       26       -3     
Flag Coverage Δ
cli-hooks 94.40% <ø> (ø)
cli-test 94.40% <ø> (ø)
logger 94.40% <ø> (ø)
oauth 94.40% <ø> (ø)
socket-mode 94.40% <ø> (ø)
web-api 94.40% <ø> (ø)
webhook 94.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cchensh cchensh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Thanks @zimeg! Matching the arguments to the reference order makes this so much easier to check against the docs page.
Left a couple of comments, nothing blocking 🙏

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Nice catch on enterprise, and +1 to William's hover-text suggestion.

…t_types description

Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 Thanks @zimeg! The hover text now matches the union, so enterprise shows up where folks look first.
The SortDir suggestion from before is still optional, nothing blocking 💯

…xt sort_dir

Co-authored-by: William Bergamin <25348381+WilliamBergamin@users.noreply.github.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg

zimeg commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind reviews @mwbrooks @cchensh and @WilliamBergamin!

@zimeg
zimeg merged commit de3e7e5 into main Nov 20, 2026
22 checks passed
@zimeg
zimeg deleted the zimeg-fix-assistant-search-context-arguments branch November 20, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants