Skip to content

feat(methods): add oauth.v2.completeShortTokenRotation method example - #435

Closed
zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-examples-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-examples-complete-short-token-rotation
Closed

zimeg wants to merge 1 commit into
zimeg-feat-oauth-v2-examples-begin-short-token-rotationfrom
zimeg-feat-oauth-v2-examples-complete-short-token-rotation

Conversation

@zimeg

@zimeg zimeg commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds a method example for oauth.v2.completeShortTokenRotation in methods/src/oauth/v2/oauth-v2-complete-short-token-rotation.js, and lists it in methods/README.md.

  • The arguments follow the order of the reference page, with its example values.

This is part 2 of 3 in the oauth examples stack (batch B6 oauth tokens). Each pull request builds on the one before it and merges on its own, bottom to top. The stack starts on main.

  1. feat(methods): add oauth.v2.beginShortTokenRotation method example #434 oauth.v2.beginShortTokenRotation
  2. feat(methods): add oauth.v2.completeShortTokenRotation method example #435 oauth.v2.completeShortTokenRotation 👈 this pull request
  3. feat(methods): add oauth.v2.user.access method example #436 oauth.v2.user.access

Dependency

This depends on slackapi/node-slack-sdk#2871, which adds oauth.v2.completeShortTokenRotation to @slack/web-api. It hasn't been released yet, so npm run check fails until a release ships it and methods/package.json pins that version. The example type-checks and runs against a local build of that branch.

Testing

  1. cd methods/src/oauth/v2 && slack install --environment local.
  2. Within 10 minutes of running oauth-v2-begin-short-token-rotation.js, replace the example values with the same credentials, the original token and its new_token, then slack run oauth-v2-complete-short-token-rotation.js and confirm the token.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg force-pushed the zimeg-feat-oauth-v2-examples-begin-short-token-rotation branch from a0804d2 to 422dc93 Compare November 18, 2026 06:23
@zimeg
zimeg force-pushed the zimeg-feat-oauth-v2-examples-complete-short-token-rotation branch from c3d0fe0 to 7b66e9c Compare November 18, 2026 06:23
@zimeg

zimeg commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closing for now. Short-secret tokens only exist for apps created before August 2016, so these rotation methods aren't in scope for this release.

@zimeg zimeg closed this Nov 18, 2026
@zimeg
zimeg deleted the zimeg-feat-oauth-v2-examples-complete-short-token-rotation branch November 18, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant