ec2 instance enumeration#3
Open
mike-bailey wants to merge 7 commits intoslack-ruby:masterfrom
Open
Conversation
Contributor
Author
|
yeah I kinda figured as such - please ignore me until cases passed |
Contributor
Author
|
Please let me test this live again too before you merge - I noticed a major F up. |
Contributor
Author
|
|
Contributor
Author
|
It'll fail - it's a Travis CI problem, not a me problem. See my slack-google-bot PR for more. |
Collaborator
|
Thanks. I can fix Travis separately, this project hasn't been updated for a while. This needs tests, README and CHANGELOG updates either way, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately literally the only proper command we use at work that's standardized. The rest are either hacky or dependent on things (i.e. @AWSbot ec2 run has an AMI hardcoded), etc.