feat(release): manual on-demand binary release trigger (Path B)#390
Merged
Conversation
release-plz can only version the 2 publishable leaf libs (uffs-time/ uffs-text) — it physically cannot see changes to uffs-cli/core/daemon/… (their cargo package cannot resolve unpublished internal deps), so it never drives binary releases. Decouple the two cadences: - BINARY release = manual on-demand. New `just release-pr [level]` bumps the lockstep workspace version via cargo set-version, refreshes the lockfile, and opens a release/vX.Y.Z PR; after squash-merge, `just release-tag` creates the signed vX.Y.Z tag -> release.yml builds the 15-platform binaries. Sole owner of the version number; restores the pre-R5 just-ship model without resurrecting the deleted ~1430 LOC. - crates.io publishing = release-plz, demoted to workflow_dispatch-only (push: main trigger disabled BY DESIGN). A normal merge triggers no release. Leaf-lib publishing is manual/occasional. Kept: R1 commit hooks, R2 git-cliff changelog, R7 dormant OIDC job, release.yml. Documented as a Path B row in release-automation-plan §8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path B — decouple binary release from crates.io publishing
Problem: release-plz only bumps the version when a publishable crate changes, and the only publishable crates are the 2 dependency-free leaves (
uffs-time/uffs-text). So a change touffs-cli/uffs-core/uffs-daemon/… never triggers a version bump or a binary build. This is structural — release-plz computes versions bycargo package-ing each tracked crate, which hard-fails for any crate with a versioned path-dep on an unpublished crate. The pre-R5 "touch anything → bump → binaries" model silently became "touch a leaf lib → bump."Fix: decouple the two release cadences.
1. Binary release = manual on-demand (sole version owner)
just release-pr [patch|minor|major]— bumps the lockstep[workspace.package].versionviacargo set-version, refreshes the lockfile, opens arelease/vX.Y.ZPR.just release-tag— after squash-merge, creates the signedvX.Y.Ztag →release.ymlbuilds the 15-platform binaries.just shipmodel without resurrecting the ~1430 LOC R5 deleted (justcargo set-version+ two thin recipes).2. crates.io publishing = release-plz, demoted
push: branches: [main]trigger disabled by design (nowworkflow_dispatch-only). release-plz no longer auto-drives anything; it's a manual helper for the 2 leaf libs.mainnow triggers no release — manual-on-demand by design, not the "nothing happened" bug.Kept intact
R1 commit-convention hooks · R2 git-cliff changelog · R7 dormant OIDC publish job ·
release.yml.Files
just/build.just—release-pr/release-tagrecipes (retiredversion-bumpstub redirects here).github/workflows/release-plz.yml— push trigger disabled by designdocs/architecture/release-automation-plan.md— Path B deviations-log row🤖 Generated with Claude Code