This repository was archived by the owner on Apr 18, 2023. It is now read-only.
Add SPDX License Identifier to Multicall2.sol#43
Open
Gilgames000 wants to merge 1 commit intosky-ecosystem:masterfrom
Open
Add SPDX License Identifier to Multicall2.sol#43Gilgames000 wants to merge 1 commit intosky-ecosystem:masterfrom
Gilgames000 wants to merge 1 commit intosky-ecosystem:masterfrom
Conversation
It fixes the compiler warning `license identifier not provided in source file` and is overall good practice to add the license identifier on a per-file basis as in the software industry no license specified defaults to all rights reserved, which could potentially prevent anyone to have the rights to deploy the individual Multicall2.sol. Though, this is technically not necessary in the particular case of MIT and Unlicense licenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes the compiler warning
license identifier not provided in source fileand is overall good practice to add the license identifier on a per-file basis as in the software industry no license specified defaults to all rights reserved, which could potentially prevent anyone to have the rights to deploy the individual Multicall2.sol. Though, this is technically not necessary in the particular case of MIT and Unlicense licenses.