Repository navigation
Cast optional bridged closure parameters to an optional function type - #298
Merged
Merged
Conversation
Converting an optional closure parameter from Java emitted `SwiftClosureN.closure(forJavaObject:options:) as (P) -> R`, casting the optional result to a non-optional function type, which does not compile. Cast to `((P) -> R)?` instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
marcprux
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A bridged function or init that takes an optional closure fails to compile on Android:
The generated Swift support code casts the optional result of
SwiftClosureN.closure(forJavaObject:options:)to a non-optional function type:This affects all optional closure parameters, with or without
@MainActor.Fix
When the parameter is optional, cast to the optional function type. Non-optional closures are unchanged (
closure(...)! as (P) -> R).Tests
Added
testFunctionOptionalClosureParametertoBridgeToKotlinTests.SkipSyntaxTestspass. Also checked withswiftc -swift-version 6that the new cast type-checks against the(@Sendable (P0) -> R)?return type ofclosure(forJavaObject:options:).🤖 Generated with Claude Code