Skip to content

Preserve coroutine Job in generated async bridge R8 rules #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcprux merged 4 commits into from
Oct 11, 2026
Merged

Preserve coroutine Job in generated async bridge R8 rules #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71189c2
Preserve coroutine Job in generated async bridge R8 rules
piercifani Oct 7, 2026
7d0daf5
Move R8 upgrade guidance to the documentation site
piercifani Oct 7, 2026
0561268
Remove comment on kotlinx.coroutines.Job reference
piercifani Oct 8, 2026
70b0c9a
Keep Job.cancel in generated async bridge R8 rules
piercifani Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/SkipBuild/SkipProject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3848,6 +3848,7 @@ internal fun PresentationRootView(context: ComposeContext) {
-keep class skip.** { *; }
-keep class tools.skip.** { *; }
-keep class kotlin.jvm.functions.** {*;}
-keep interface kotlinx.coroutines.Job { void cancel(java.util.concurrent.CancellationException); }
-keep class com.sun.jna.** { *; }
-dontwarn java.awt.**
-keep class * implements com.sun.jna.** { *; }
Expand Down
3 changes: 3 additions & 0 deletions Tests/SkipBuildTests/SkipCommandTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,6 +1267,9 @@ final class SkipCommandTests: XCTestCase {
/// A single-module native app
func testLibInitAppNativeAppCommand() async throws {
let (projectURL, projectTree) = try await skipInit(projectName: "cool-app", zero: false, mode: [.nativeApp], tests: nil, fastlane: false, appid: "some.cool.app", swiftPackageVersion: "6.2", moduleNames: "AppModule")
let proguardRules = try String(contentsOf: projectURL.appendingPathComponent("Android/app/proguard-rules.pro"))
XCTAssertTrue(proguardRules.split(separator: "\n").contains("-keep interface kotlinx.coroutines.Job { void cancel(java.util.concurrent.CancellationException); }"),
"Native apps must preserve the Job return type used in async bridge JNI signatures and the Job.cancel method that bridged task cancellation calls")
XCTAssertEqual(projectTree ?? "", """
.
├─ Android
Expand Down
Loading