Repository navigation
Conversation
add() returned without enqueueing work unless a delegate was set and willPresent included banner or alert. Scheduling no longer depends on that callback. NotificationWorker also uses a platform status icon when the app has neither a notification icon nor a launcher icon, instead of failing on resource id 0.
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @shiaho777 on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNUserNotificationCenter.addreturned without scheduling anything unless a delegate was set andwillPresentincluded.banneror.alert. On iOS,addschedules the notification either way, andwillPresentruns only when a notification fires while the app is in the foreground.Scheduling no longer consults the delegate.
NotificationWorkeralso used to callIconCompat.createWithResourcewith resource id 0 when the app had neitheric_notificationnoric_launcher, which failed the worker. It now falls back toandroid.R.drawable.stat_notify_chat.