Repository navigation
Conversation
titleSmall and bodyMedium share 14sp/20sp, so sizes are unchanged, but titleSmall is Medium (500) where iOS's subheadline is regular. Text set in .subheadline therefore read heavier than its iOS counterpart. bodyMedium is the token .callout already uses. Its letter spacing is 0.25sp rather than 0.1sp, so the text sets slightly wider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.subheadlinemaps totitleSmall, which is Medium (500); iOS draws it at the regular weight. This maps it tobodyMedium: the same 14/20sp, regular weight, and the token.calloutalready uses.Before / after
Showcase → Text. Fuse; Lite is pixel-identical.
Measured, not eyeballed: ink per pixel of text width on the
Font.subheadlinerow goes from 8.9 to 7.2. For scale,.body(regular, 16sp) is 7.8 and.headline(medium, 16sp) 9.7.Side effects
Height unchanged (
testTextSizeSubheadlinestill passes; the row is 43 px in both arms).bodyMedium's letter spacing is 0.25sp rather than 0.1sp, so text sets slightly wider and can rewrap. The playground's long subheadline paragraph keeps its 3 lines but moves one word:Nothing else in skip-ui uses
.subheadline. Every other row on the two captured screens (top and bottom of the Text playground) is pixel-identical.Apple platforms: none (
#if SKIP).Verified
swift test: 119 Swift tests, 54 skipped, 0 failures. JUnit: 163, 158 passed, 5 skipped.testSubheadlineIsRegularWeight; withmain'sFont.swiftit fails on its own assertion (FontWeight(weight=400) != FontWeight(weight=500)).Skip Pull Request Checklist:
swift test.subheadlinerows.Written with Claude Code. Every claim above comes from a run: the mutation run, and the Showcase on an emulator before and after with pixel diffs and the ink measurement, and on a simulator.