[25911] Add Waupaca rider categories and SMS consent disclaimer - #538
Merged
Conversation
…y selection flag - updated WaupacaApplication to enable rider category selection - updated Client models to decode rider categories, category descriptions, and SMS disclaimers - added AccountClientConfig for localized server-driven account configuration - updated UserData to preserve raw appData and expose rider category helpers - updated UpdateUserRequest and UserApi to support complete appData updates - updated UserAccountRepository to fetch, merge, and save rider category selections safely - updated HomeViewModel and HomeFragment with guarded first-time category prompting - added RiderCategoriesView for reusable editable and read-only category selection - updated AccountActivity and AccountActivityViewModel to display saved categories and SMS disclaimers - updated AccountEditActivity and AccountEditViewModel to edit, validate, and save rider categories - updated account layouts with rider category sections and SMS disclaimer text - updated account strings with localized rider category labels - updated AppSelectionFragment and AppSelectionViewModel to refresh cached Waupaca client configuration - updated CustomBinding to show profile placeholders for missing or failed image URLs - updated account view models to use ic_profile_round as the profile placeholder - added client configuration, appData merge, repository, prompting, and locale fallback tests - updated DefaultServer to use a trailing slash for the beta API URL - updated ServerTest to validate trailing slashes for all default server URLs - updated app build configuration with Catch a Ride signing credentials and Leicester version changes
…5911-rider-category-selection
|
✅ Unit tests passed successfully! Test results are available under the "Artifacts" section of this run in GitHub Actions. Please ensure the code is reviewed before proceeding with the merge. |
|
✅ Unit tests passed successfully! Test results are available under the "Artifacts" section of this run in GitHub Actions. Please ensure the code is reviewed before proceeding with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use
[x]to check a box, e.g.,[x], and make sure there's no space around the brackets.PR Context
appDatapersistence. The feature is disabled by default and enabled only for Waupaca.Changes
tripgosdk, guarded byTripGoConfigs.hasRiderCategorySelection().appData.Checklist for Reviewers
Documentation and Code Quality
Testing and Reliability
Error Handling and Logging
Testing Procedure
categories_prompted_at. Verify the account completion screen opens once and displays the configured rider categories and SMS disclaimer.appDataremains intact../gradlew :TripKitData:testDebugUnitTest./gradlew :tripgosdk:testDebugUnitTest./gradlew :app:compileWaupacaDebugKotlinWork-in-Progress (WIP)
Remember to keep this template updated based on the feedback and evolving project standards.