Skip to content

test: Avoid -ffinite-math-only on floating point comparisons #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iv-m wants to merge 2 commits into
base: master
Choose a base branch
from
+30 −22
Open

test: Avoid -ffinite-math-only on floating point comparisons #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7d2363
test: Avoid -ffinite-math-only on floating point comparisons
iv-m Jan 21, 2026
7afd6ea
gh-actions: test -Ofast instead of -ffast-math
mr-c Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,12 @@ jobs:
distro: ubuntu-24.04
- version: 10
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 11
distro: ubuntu-24.04
- version: 11
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 11
distro: ubuntu-24.04-arm
- version: 11
Expand All @@ -302,28 +302,28 @@ jobs:
distro: ubuntu-24.04
- version: 12
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 12
distro: ubuntu-24.04-arm
- version: 13
distro: ubuntu-24.04
- version: 13
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 13
distro: ubuntu-24.04-arm
- version: 14
distro: ubuntu-24.04
- version: 14
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 14
distro: ubuntu-24.04-arm
- version: 15
distro: ubuntu-24.04
- version: 15
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: 15
distro: ubuntu-24.04-arm
- version: 15
Expand Down Expand Up @@ -690,54 +690,54 @@ jobs:
distro: ubuntu-22.04
- version: "12"
distro: ubuntu-22.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: "13"
distro: ubuntu-22.04
- version: "13"
distro: ubuntu-22.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: "14"
distro: ubuntu-24.04
- version: "14"
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: "14"
distro: ubuntu-24.04-arm
arch_flags: -march=armv8-a+fp+aes+sha2
plain: true
# grep Features < /proc/cpuinfo | head -n 1 | awk '-F: ' '{print $2}' | sed 's/asimd //;s/evtstrm //;s/pmull //;s/sha1 //;s/crc32 //;s/atomics //;s/fphp //;s/asimd.. //g;s/cpuid //;s/asimd... //g;s/jscvt //;s/fcma //;s/lrcpc //;s/dcpop //;s/sm3 //;s/sha512 //;s/uscat //;s/ilrcpc //;s/pac. //g;s/dcpodp //;s/sveaes //;s/svebitperm //;s/svesha3 //;s/svesm4 //;s/flagm2 //;s/frint //;s/svei8mm //;s/svebf16 //' | tr ' ' '+'
- version: "14"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -march=armv8-a+fp+aes+sha2
arch_flags: -Ofast -march=armv8-a+fp+aes+sha2
plain: true
- version: "15"
distro: ubuntu-24.04
- version: "15"
distro: ubuntu-24.04
arch_flags: -ffast-math
arch_flags: -Ofast
- version: "15"
distro: ubuntu-24.04-arm
- version: "15"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math
arch_flags: -Ofast
- version: "16"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage
- version: "16"
distro: ubuntu-24.04
arch_flags: -ffast-math -Wno-unsafe-buffer-usage
arch_flags: -Ofast -Wno-unsafe-buffer-usage
- version: "16"
distro: ubuntu-24.04-arm
arch_flags: -Wno-unsafe-buffer-usage
- version: "16"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -Wno-unsafe-buffer-usage
arch_flags: -Ofast -Wno-unsafe-buffer-usage
- version: "17"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage
- version: "17"
distro: ubuntu-24.04
arch_flags: -ffast-math -Wno-unsafe-buffer-usage
arch_flags: -Ofast -Wno-unsafe-buffer-usage
- version: "17"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage -O2
Expand All @@ -746,7 +746,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage
- version: "17"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -Wno-unsafe-buffer-usage
arch_flags: -Ofast -Wno-unsafe-buffer-usage
- version: "17"
distro: ubuntu-24.04-arm
arch_flags: -Wno-unsafe-buffer-usage -O2
Expand All @@ -755,7 +755,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "18"
distro: ubuntu-24.04
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -Ofast -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "18"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand All @@ -764,7 +764,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "18"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -Ofast -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "18"
distro: ubuntu-24.04-arm
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand All @@ -773,7 +773,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "19"
distro: ubuntu-24.04
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -O3 -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "19"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand All @@ -782,7 +782,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "19"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -O3 -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "19"
distro: ubuntu-24.04-arm
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand All @@ -791,7 +791,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "20"
distro: ubuntu-24.04
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -O3 -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "20"
distro: ubuntu-24.04
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand All @@ -800,7 +800,7 @@ jobs:
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default
- version: "20"
distro: ubuntu-24.04-arm
arch_flags: -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
arch_flags: -O3 -ffast-math -Wno-unsafe-buffer-usage -Wno-switch-default -Wno-nan-infinity-disabled
- version: "20"
distro: ubuntu-24.04-arm
arch_flags: -Wno-unsafe-buffer-usage -Wno-switch-default -O2
Expand Down
8 changes: 8 additions & 0 deletions test/test.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ simde_test_debug_printf_(const char* format, ...) {
HEDLEY_DIAGNOSTIC_PUSH
SIMDE_DIAGNOSTIC_DISABLE_FLOAT_EQUAL_

#if defined(SIMDE_FAST_MATH) && defined(HEDLEY_GCC_VERSION) && HEDLEY_GCC_VERSION_CHECK(4,4,0)
__attribute__((optimize("-fno-finite-math-only")))
__attribute__((noinline))
#endif
static int
simde_test_equal_f32(simde_float32 a, simde_float32 b, simde_float32 slop) {
if (simde_math_isnan(a)) {
Expand Down Expand Up @@ -156,6 +160,10 @@ simde_test_equal_f16(simde_float16 a, simde_float16 b, simde_float16 slop) {
return simde_test_equal_f32(af, bf, slopf);
}

#if defined(SIMDE_FAST_MATH) && defined(HEDLEY_GCC_VERSION) && HEDLEY_GCC_VERSION_CHECK(4,4,0)
__attribute__((optimize("-fno-finite-math-only")))
__attribute__((noinline))
#endif
static int
simde_test_equal_f64(simde_float64 a, simde_float64 b, simde_float64 slop) {
if (simde_math_isnan(a)) {
Expand Down
Loading