Merged
Conversation
loichuder
approved these changes
Feb 9, 2026
axelboc
force-pushed
the
memo-axis-scales
branch
from
b76ad5f to
f8344d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to this optimisation, the axis scales and all the memoised functions that depend on them like
worldToData,getVisibleDomains, etc. are now stable when, for instance, the grid gets toggled.I don't think it makes a noticeable difference in the viewer. It just makes things more predictable internally and for consumer applications. It also opens the door to more targeted optimisations with
memo,useMemo,useCallback, etc.